Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding bandpass for the Kepler spacecraft #60

Merged
merged 2 commits into from
Jan 15, 2015
Merged

Conversation

mrtommyb
Copy link
Contributor

adding the response function found at
http://keplergo.arc.nasa.gov/CalibrationResponse.shtml

@kbarbary
Copy link
Member

Cool!

Note that this alone won't allow one to automatically load the bandpass via, e.g., get_bandpass("kepler"). That requires adding a bit of code to sncosmo/_builtins/bandpasses.py. You can add it to this PR or I can do it after merging if you'd like.

@mrtommyb
Copy link
Contributor Author

if it is as simple as adding the code below then I can do this. Is there anything else?

kepler_meta = {
    'filterset': 'kepler',
    'retrieved': '14 Jan 2015',
    'description': 'Bandpass for the Kepler spacecraft',
    'dataurl': 'http://keplergo.arc.nasa.gov/CalibrationResponse.shtml,}
registry.register_loader(Bandpass, 'kepler', load_bandpass,
                         args=['../data/bandpasses/kepler.dat'], meta=kepler_meta)

@kbarbary
Copy link
Member

Yep, that's it!

@kbarbary
Copy link
Member

Thanks! The test failure is just due to the PEP8 style checker which gets run automatically.

kbarbary added a commit that referenced this pull request Jan 15, 2015
pep8 failure, but can fix it later
@kbarbary kbarbary merged commit 60b87a8 into sncosmo:master Jan 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants