Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing bin directory #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing bin directory #2

wants to merge 1 commit into from

Conversation

dgchrt
Copy link

@dgchrt dgchrt commented Nov 6, 2020

This should fix missing bin directory creation on Makefile #1

algodesigner
algodesigner approved these changes Sep 3, 2021
View reviewed changes
Copy link

@algodesigner algodesigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered the same problem during the build. The proposed fix works.

@vrgimenez
Copy link

Same here, the proposed fix works

@dgchrt
Copy link
Author

dgchrt commented Sep 18, 2021

@sndpl, can you also review this change?

@algodesigner
Copy link

I ended up forking this project to fix this problem along with the runtime assembly code to pass in the program name on MSX-DOS2 and (int argc, char *argv) in the right order to make it C-compliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algodesigner algodesigner algodesigner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgchrt @vrgimenez @algodesigner