Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSR support. Fix window is not defined error #73

Closed
vpetrusevici opened this issue Mar 16, 2022 · 5 comments
Closed

SSR support. Fix window is not defined error #73

vpetrusevici opened this issue Mar 16, 2022 · 5 comments
Labels
enhancement New feature or request released

Comments

@vpetrusevici
Copy link
Contributor

Is it possible to add check like
if (typeof window !== 'undefined')
in this place

img-comparison-slider/src/index.ts

Line 396 in 15f44f2

window.customElements.define(
?
Because for now Angular Universal throw error 'window is not defined'.
I can create a PR if you do not mind
@sneas sneas added the enhancement New feature or request label Mar 16, 2022
@sneas
Copy link
Owner

sneas commented Mar 16, 2022

Hi @vpetrusevici, yes, please do. Thank you in advance!

@vpetrusevici vpetrusevici mentioned this issue Mar 16, 2022
Merged
@vpetrusevici
Copy link
Contributor Author

PR is ready

@sneas sneas closed this as completed in 7251b81 Mar 16, 2022
sneas pushed a commit that referenced this issue Mar 16, 2022
@semantic-release-bot
chore(release): 7.5.2 [skip ci]
584e987 
## [7.5.2](v7.5.1...v7.5.2) (2022-03-16)

### Bug Fixes

* ssr support ([7251b81](7251b81)), closes [#73](#73)
@sneas
Copy link
Owner

sneas commented Mar 16, 2022

🎉 This issue has been resolved in version 7.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sneas sneas added the released label Mar 16, 2022
@vpetrusevici
Copy link
Contributor Author

So fast! Thanks!

@sneas
Copy link
Owner

sneas commented Mar 16, 2022

CI/CD 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sneas @vpetrusevici