Advanced Riding fix #228
Closed
Advanced Riding fix #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aion2501
approved these changes
Jun 21, 2019
cizra
requested changes
Jun 25, 2019
| @@ -356,7 +356,9 @@ int TBeing::doGet(const char *a) | |||
| if (fight()) | |||
| return FALSE; // don't fall through | |||
| } | |||
| if (dynamic_cast<TBeing *>(riding)) { | |||
| if ((riding && dynamic_cast<TBeing *>(riding)) | |||
There was a problem hiding this comment.
Why all these parentheses? We need none of them.
|
|
||
| if (getPosition() > POSITION_STANDING && | ||
| !(getPosition() == POSITION_MOUNTED && | ||
| doesKnowSkill(SKILL_ADVANCED_RIDING) && (getSkillValue(SKILL_ADVANCED_RIDING) >= 50))) { |
There was a problem hiding this comment.
The doesKnowSkill looks redundant with getSkillValue. Is it possible to have skill value and still not know it?
| act("$n sits down in a position of penance.", TRUE, this, 0, 0, TO_ROOM); | ||
| setPosition(POSITION_RESTING); | ||
| } else { | ||
| sendTo("You begin to chant.\n\r"); |
There was a problem hiding this comment.
Can you move your mount while doing penance?
|
gunna open a new PR on this from a different branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making some QOL improvements for mounted deikhans.