Add skill to advanced defense #265
Conversation
| @@ -223,6 +223,7 @@ static int bash(TBeing *c, TBeing *victim, spellNumT skill) | |||
| (bKnown > 0) && | |||
| (i != GUARANTEED_FAILURE) && | |||
| (!victim->canCounterMove(bKnown)) && | |||
| (!victim->canFocusedAvoidance(bKnown/2)) && | |||
There was a problem hiding this comment.
The () aren't necessary, but they don't hurt either.
code/code/cmd/cmd_bonebreak.cc
Outdated
|
|
||
| if (victim->canFocusedAvoidance(bKnown/2)) { | ||
| SV(SKILL_BONEBREAK); | ||
| rc = bonebreakMiss(caster, victim, 2); |
There was a problem hiding this comment.
Instead of a function call (or perhaps inside that function call), I'd just have an array of string triples. Look up the strings and print them — less code lines and no branch mispredictions in CPU.
There was a problem hiding this comment.
Not saying you should go and refactor everything in the world, though :)
|
|
||
| CDDefense::CDDefense() : | ||
| CDiscipline(), | ||
| skAdvancedDefense() | ||
| skAdvancedDefense(), | ||
| skFocusedAvoidance() |
There was a problem hiding this comment.
Chances are that these constructors, destructors, operator= don't do anything useful and should be deleted.
| @@ -1404,6 +1404,7 @@ class TBeing : public TThing { | |||
| bool checkSmashed(TBeing *, wearSlotT, spellNumT, TThing *, int, const char * = NULL); | |||
| int hit(TBeing *, int pulse = -1); | |||
| bool canCounterMove(int); | |||
| bool canFocusedAvoidance(int); | |||
There was a problem hiding this comment.
I wonder why these skills live in TBeing? This causes horrible recompilation times for everything, as well as leaking inner workings of disciplines into generic code of beings.
As most things in TBeing are public, maybe it makes more sense to have that code in disciplines?
There was a problem hiding this comment.
Seems like all the combat type code is dealing with two objects that are subclasses of TBeing of some sort. So it kind of makes sense to be able to write
if (victim->canFocusedAvoidance(bKnown/2)) {
I guess the other option would just be
if (canFocusedAvoidance(victim, bKnown/2)) {
Just not object oriented. It seems a little easier to reason about in the first instance but if the performance impact is huge the other way it's not a big deal to change it all.
I feel like "Disciplines" or "Abilities" maybe should be a class that is instantiated per being.
adding a skill to advanced defense for warriors and deikhans. This is very similar in concept to counter move for monks. Lets the tank classes have a chance to avoid some debilitating special moves.