Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for DatePicker, DatePickerInput and DatesProvider #37

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

AnnMarieW
Copy link
Sponsor Collaborator

@AnnMarieW AnnMarieW commented Oct 4, 2023

Added docs for DatePicker, DatePickerInput and DatesProvider

I created a separate PR because I think these components may take longer to review and I didn't want to hold up #36

Breaking changes (not a complete list):

  • DatePickerRange component removed, use DatePickerInput with `type="range"
  • DatePicker component is just the calendar now. Use DatPickerInput when migrating from previous versions.
  • use datesProvider to set locale
  • inputFormat prop renamed to valueFormat
  • amountOfMonths prop was renamed to numberOfColumns in all components
  • clearable=False is now the default in DatePickerInput

Bugs:

  • Need a better error message if using type="multiple" and the value is not a list. Currently the error message is "t.map is not a function"

  • locale prop only works in the DatesProvider and not in DatePicker or DatePickerInput

  • Missing props

    • defaultDate - Sets calendar to a date other than current date. See the example docs.datepicker.min_max

    • defaultLevel. There is level prop but no defaultLevel prop. Level doesn't work as in the docs: https://v6.mantine.dev/dates/date-picker/#default-level. See the example docs.datepicker.default_level

@AnnMarieW AnnMarieW changed the base branch from main to mantine@v6 October 4, 2023 23:17
@snehilvj snehilvj merged commit 9368e42 into snehilvj:mantine@v6 Oct 5, 2023
@snehilvj
Copy link
Owner

snehilvj commented Oct 5, 2023

Thanks again @AnnMarieW

@AnnMarieW AnnMarieW mentioned this pull request Oct 5, 2023
28 tasks
@AnnMarieW AnnMarieW deleted the amw-mantine@v6-date branch October 6, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants