Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There should be a WebClient instead of a GitlabClient #19

Closed
schettn opened this issue May 13, 2020 · 0 comments · Fixed by #21, #25 or #43
Closed

There should be a WebClient instead of a GitlabClient #19

schettn opened this issue May 13, 2020 · 0 comments · Fixed by #21, #25 or #43
Assignees
@schettn
Labels
enhancement New feature or request
Projects
SNEK Network for Engineers and Knowle...

Comments

@schettn
Copy link
Member

schettn commented May 13, 2020

Describe the feature or change you'd like
Currently the only client which has access to the scraper endpoint is the GitlabClient. Using this client for other use cases is not sufficient. Therefore a general WebClient should be implement which can handle all request to the scraper endpoint.
@schettn schettn added the enhancement New feature or request label May 13, 2020
@schettn schettn self-assigned this May 13, 2020
@schettn schettn mentioned this issue May 13, 2020
Merged
6 tasks
@schettn schettn linked a pull request May 13, 2020 that will close this issue
Improve client 1 to implement 1 #21
Merged
6 tasks
@schettn schettn mentioned this issue May 13, 2020
Merged
6 tasks
@schettn schettn linked a pull request May 13, 2020 that will close this issue
Improve client 2 to implement 1 #25
Merged
6 tasks
@schettn schettn closed this as completed May 20, 2020
@schettn schettn added this to Done in SNEK Network for Engineers and Knowledged via automation May 20, 2020
@schettn schettn mentioned this issue May 29, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schettn schettn

Labels
enhancement New feature or request
Projects
No open projects
SNEK Network for Engineers and Knowle...
  
Done
Milestone
No milestone
1 participant
@schettn