Improve client 1 to implement 1 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A description for the url parameter has been added.
Now the client can handle string in "protocol://foo.bar" and "foo.bar" format. By default the http protocol will be appended if no other protocol is specified.
The GitlabClient has been replaced with a WebClient. This has been done because gitlab does not require a own client. The WebClient can handle all its needs.
Aichnerc
added this to Reviewer approved
in SNEK Network for Engineers and Knowledged
via automation
This was
linked to
issues
May 13, 2020
pinterid
reviewed
May 13, 2020
| ep.url = ((url: string) => { | ||
| if (!/^(?:f|ht)tps?\:\/\//.test(url)) { | ||
| url = "http://" + url; | ||
| } |
SNEK Network for Engineers and Knowledged
automation
moved this from Reviewer approved
to Review in progress
May 13, 2020
The code quality has been improved due to a request of @pinterid.
SNEK Network for Engineers and Knowledged
automation
moved this from Review in progress
to Reviewer approved
May 13, 2020
SNEK Network for Engineers and Knowledged
automation
moved this from Reviewer approved
to Done
May 13, 2020
This was referenced May 13, 2020
schettn
added a commit
to snek-at/intel
that referenced
this pull request
May 13, 2020
Due to a new snek-client release, the client has to be replaced. Ref: snek-at/client#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior? (link to any open issues here)
What is the new behavior (if this is a feature change)?
Other information: