Skip to content

Commit

Permalink
Docs: roadmap, internals, docstrings
Browse files Browse the repository at this point in the history
  • Loading branch information
ashwinvis committed Aug 3, 2020
1 parent 3458bf4 commit 2fae4b3
Show file tree
Hide file tree
Showing 7 changed files with 43 additions and 27 deletions.
7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,6 @@ sim.make.exec(["run"]) # actual simulation
not so hard, btw)

## Roadmap

### Short term
- Implement post processing API: with matplotlib and Paraview

### Long term
- Interface Nek5000 states and time-integration event loop

## Contributing

Contributions are welcome! You can help by testing out the code, filing issues
Expand Down
2 changes: 1 addition & 1 deletion docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Welcome to *snek5000*'s documentation!
:caption: Help & Reference

roadmap
boundary_cond
internals
filtering
CONTRIBUTING
CHANGELOG
Expand Down
27 changes: 13 additions & 14 deletions docs/boundary_cond.rst → docs/internals.rst
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
Notes on Nek5000 internals
##########################

Boundary condition
==================

Expand Down Expand Up @@ -52,13 +55,13 @@ Also if ``igeom=2``:
- bdry?
- ``opmask``: set 0 to dirichlet BC, masked from the update

Boundary conditions
-------------------
Boundary condition subroutines
------------------------------

Periodicity: node numbering

``bcdirvc``
~~~~~~~~~~~
``bcdirvc``: Dirichlet
~~~~~~~~~~~~~~~~~~~~~~

- ``CB = V (Constant Dirichlet in rea file)``
- ``CB = v (user provided Dirichlet in userbc)``:
Expand Down Expand Up @@ -102,19 +105,15 @@ No mask

Velocity should be ``v=0``

Caution: Pressure preconditioner BC are related

To Do
~~~~~
Caution: Pressure preconditioner and BC are related

Set velocity v=0, normal component of velocity is zero, opposite of
``on`` boundary condition.
.. todo::

FAQ
===
Set velocity v=0, normal component of velocity is zero, opposite of ``on``
boundary condition.

Time-stepping algebra
---------------------
=====================

Mass matrix requires time levels (n, n-1, n-2): extrapolated Conv /
Stiffness requires time levels (n-1, n-2): explicit
Expand All @@ -133,4 +132,4 @@ correction in each sub-step.
CFL number
~~~~~~~~~~

BDF3/EXT3: CFL=0.6. Characteristic emthod
BDF3/EXT3: CFL=0.6. Characteristic method
21 changes: 21 additions & 0 deletions docs/roadmap.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
Roadmap
=======

Short term
----------

- Implement post processing API: with matplotlib and Paraview. Status:
* Paraview_ reader is implemented. Requires clean up.
* Pymech_ reader which extends xarray is implemented.

.. _paraview: https://github.com/exabl/sandbox/blob/master/paraview/nekio.py
.. _pymech: https://pymech.readthedocs.io/en/latest/dataset.html

Long term
---------

- Interface Nek5000 states and time-integration event loop. Status:
* Experiments are underway to interface using cffi_.

.. _cffi: https://github.com/exabl/sandbox/tree/master/interface/test_case

Miscellaneous
-------------

.. todolist::

4 changes: 2 additions & 2 deletions src/snek5000/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,22 @@
.. autosummary::
:toctree:
assets
output
solvers
util
**Modules**
.. autosummary::
:toctree:
assets
info
log
magic
make
operators
params
util
"""
import importlib.resources
Expand Down
6 changes: 6 additions & 0 deletions src/snek5000/assets/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
"""Assets for building
======================
Contains common snakemake rules and jinja templates.
"""
3 changes: 0 additions & 3 deletions src/snek5000/operators.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
Information regarding mesh, mathematical operators, and domain decomposition.
.. todo:: Move length to abl.par file and extrude it to allow double precision
values.
.. note:: We deliberately try not to use the variable names used in Nek5000, as
those are ambiguously named.
Expand Down

0 comments on commit 2fae4b3

Please sign in to comment.