Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Change "Zoom" to "Scale" #81

Closed
FitzRoyX opened this issue Sep 11, 2022 · 5 comments
Closed

Suggestion: Change "Zoom" to "Scale" #81

FitzRoyX opened this issue Sep 11, 2022 · 5 comments

Comments

@FitzRoyX
Copy link
Contributor

Zoom is not really the appropriate term here and usually means to blow up part of an image without affecting window size. Also, it's awkward to set zoom levels as numbers that correspond to percentages based off a non-native res. I recommend changing to simply "Scale" multiplier and getting rid of the pre-doubling. Then 256x224 = 1, the default is 2, and "ZoomOut/In" becomes "ScaleDown/Up".

@snesrev
Copy link
Owner

snesrev commented Sep 11, 2022

It's called Zoom in chrome though

@FitzRoyX
Copy link
Contributor Author

Yes, because it's changing just the contents of the frame instead of both at once. You lose sight of things when you zoom in, like a camera.

@JasonShearer
Copy link
Contributor

"Scale" is typically used in emulators for scaling the size of the window itself. I realize this isn't an emulator, but I think the terminology suits it better. Just my two cents.

@snesrev
Copy link
Owner

snesrev commented Sep 12, 2022

Ok makes sense

snesrev added a commit that referenced this issue Sep 12, 2022
@snesrev snesrev closed this as completed Sep 12, 2022
@FitzRoyX
Copy link
Contributor Author

One last question about this. 3x scale (768x672) and 5x (viable on 1920x1200 monitors) are not possible atm because of the internal res doubling that's going on. Is there a reason or can we remove this and have the scale number = actual scale?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants