New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MetaboAnalyst export more visible #296
Comments
Is there some general format in which the data should be exported? some test files? descriptions? Implementing should then be simple and straightforward. |
Hi, Information on
http://www.metaboanalyst.ca/MetaboAnalyst/faces/docs/Format.xhtml
It would also be great if @xia-lab can give feedback whether the existing not-exported MetaboAnalyst export linked above works or needs any fixes.
Yours Steffen
…---
I blame Android for the brevity and typos
|
Hi, thank you for opening this issue. I will do some testing if it still works well with our MetaboAnalystR package and let you know. I’ll also prepare some examples on a workflow using XCMS then our package. Cheers, |
Hi, The xcms:::.write.metaboanalyst() works perfectly with our R package, creating the correct data table in the right format. From our end I've created an example workflow that I will add as a vignette/use-case in our package. Thanks! |
Great! Can you just point here to the vignette once you've added it? |
Here it is! Let me know if you have any thoughts. |
Thanks for the link! I'll have a look at it next week as I'm on a workshop this week. |
Looks nice. I'll implement a method for the newer |
Just had a look at the exported file. The supported file format is thus:
Is that correct? Is there any way that feature definitions could be added too, e.g. the rt range and mz range of the features/rows? |
And how does MetaboAnalyst handle missing values? As shown above they are exported as |
- Implement the exportMetaboAnalyst function to export an XCMSnExp feature data matrix in MetaboAnalyst format. - Add documentation and unit tests.
Yes that file format is correct, and NA is fine for missing values. Also, we currently don't make use of feature definitions so all we need is the m/z and peak intensities. We will for sure switch over once you have that ready. As well, I had an email from a user that tried our example vignette and wanted to know if it was possible to edit the decimal points for the m/z or retention time? |
Thanks for the information. Regarding the decimal point: so the user wants to use either a |
Could you check if the new |
For the decimal point it was the number of digits following the decimal, not "." or ",". And I will check the new function/your pull request now and get back to you ASAP! |
I see. No problem about that. I'll be however on holidays the next two weeks - so it will take some time... |
I've now added a |
Great! Everything looks good on our end, thank you. |
It would be great to have the possibility to replace
|
@etrh I could add a parameter to |
- Add parameter groupnames to exportMetaboAnalyst to allow using m/z and retention times as rownames (issue #296). - Fix bug in `show,XCMSnExp` that would lead to an error if process history is empty.
XCMS has for quite some time a hidden export to MetaboAnalyst
xcms/R/functions-xcmsSet.R
Line 563 in d66fd8f
I had feedback by people from @xia-lab @jsychong that this actually works, so it would be great
to have that better exposed. The current version is designed for
xcmsSet
,and the exposed version should handle both
xcmsSet
and the new interface.If the Xia lab have some code examples, they could contribute that to the documentation/manpage/examples. PR appreciated :-) Yours, Steffen
The text was updated successfully, but these errors were encountered: