Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No method to convert XcmsExperiment to xcmsSet - Version 3.99.5 #696

Closed
CollinStark opened this issue Oct 17, 2023 · 1 comment
Closed

No method to convert XcmsExperiment to xcmsSet - Version 3.99.5 #696

CollinStark opened this issue Oct 17, 2023 · 1 comment
Assignees
@jorainer

Comments

@CollinStark
Copy link

Hi, the CAMERA package (v1.57.0) requires an "xcmsSet" as an input for it's xsAnnotate method. In older xcms versions it was possible to convert the xcms preprocessing results into an "xcmsSet" with the code as(data, "xcmsSet"). Using the same code snippet in version 3.99.5 results in the following error:
Error in as(data, "xcmsSet") : no method or default for coercing “XcmsExperiment” to “xcmsSet”
@jorainer jorainer self-assigned this Oct 18, 2023
jorainer added a commit that referenced this issue Oct 18, 2023
@jorainer
fix: add method to coerce XcmsExperiment to xcmsSet
461a771 
- Add method to coerce a `XcmsExperiment` to a `xcmsSet` (issue #696).
- Fix `chromatogram,MsExperiment` to support also defining either `mz` or `rt`.
@jorainer jorainer mentioned this issue Oct 18, 2023
Merged
@jorainer
Copy link
Collaborator

jorainer commented Dec 1, 2023

closing this issue as it was implemented.

@jorainer jorainer closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorainer jorainer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorainer @CollinStark