[Bug]: A mapped WordPress hook that passes null as the first argument will throw an exception.

[calvinalkan]

Thanks for taking the time to fill out this bug report!"

• I have searched the issue tracker for similar issues
• I have verified that the issue is present when using the most recent version of the affected package(s)

Which @snicco/* package(s) are the source of the bug?

better-wp-hooks

Is this a regression?

No

Composer dependencies

//

Current behaviour

A mapped WordPress hook that passes null as the first argument will throw an exception.

Expected behaviour

Null should be allowed as a first mapped argument.

How to reproduce

 $event_mapper->map('some_hook', 'SomeClass::class');
 
 do_action('some_hook', null, 'foo', 'bar');

Possible solution

 if (! isset($args_from_wordpress_hooks[0])) {
throw new RuntimeException(
                    sprintf('Event mapper received invalid arguments from WP for mapped hook [%s].', $event_class)
 );
}

We need to use array_key_exists instead of isset in EventMapper::dispatchMappedFilter

Relevant log output

No response

Additional Context

No response

[snicco-bot]

🎉 This issue has been resolved in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀