Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SignedUrl removes non standard HTTP ports from protected target #162

Closed
2 tasks done
calvinalkan opened this issue Oct 26, 2022 · 1 comment
Closed
2 tasks done
Labels
bug Something isn't working released

Comments

@calvinalkan
Copy link
Member

Thanks for taking the time to fill out this bug report!"

  • I have searched the issue tracker for similar issues
  • I have verified that the issue is present when using the most recent version of the affected package(s)

Which @snicco/* package(s) are the source of the bug?

signed-url

Is this a regression?

No

Composer dependencies

//

Current behaviour

Signing the target url: https://foo.com:8443" will result in https://foo.com being used.

    /**
     * @psalm-suppress MixedOperand
     */
    private function getDomainAndSchema(array $parts): ?string
    {
        if (isset($parts['host'], $parts['scheme'])) {
            return $parts['scheme'] . '://' . $parts['host'];
        }

        return null;
    }

Expected behaviour

Non standard HTTP ports should not be removed.

How to reproduce

//

Possible solution

No response

Relevant log output

No response

Additional Context

No response

@calvinalkan calvinalkan added the bug Something isn't working label Oct 26, 2022
calvinalkan added a commit to calvinalkan/snicco that referenced this issue Nov 13, 2022
calvinalkan added a commit to calvinalkan/snicco that referenced this issue Nov 13, 2022
@snicco-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants