We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signed-url
No
//
Signing the target url: https://foo.com:8443" will result in https://foo.com being used.
https://foo.com:8443"
https://foo.com
/** * @psalm-suppress MixedOperand */ private function getDomainAndSchema(array $parts): ?string { if (isset($parts['host'], $parts['scheme'])) { return $parts['scheme'] . '://' . $parts['host']; } return null; }
Non standard HTTP ports should not be removed.
No response
The text was updated successfully, but these errors were encountered:
fix(signed-url): add non-standard http ports to final url if passed
0cff4c1
Fix: snicco#162
e486bba
1368c80
🎉 This issue has been resolved in version 1.5.0 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
Sorry, something went wrong.
No branches or pull requests
Thanks for taking the time to fill out this bug report!"
Which @snicco/* package(s) are the source of the bug?
signed-url
Is this a regression?
No
Composer dependencies
Current behaviour
Signing the target url:
https://foo.com:8443"
will result inhttps://foo.com
being used.Expected behaviour
Non standard HTTP ports should not be removed.
How to reproduce
//
Possible solution
No response
Relevant log output
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: