We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templating
Using the simple PHPViewFactory it is currently possible to extend a parent template by using the annotation.
PHPViewFactory
<?php /* * Extends: layout.php */ ?> <h1> Hello World </h1>
It would be nice to expand support to using doc-block annotations instead of only simple multi-line comments.
<?php /** * Extends: layout.php * * @var string $message */ ?> <h1> echo $message </h1>
The first option works currently, the second one does not.
We would need to change the regex parsing in the PHPViewFactory::parseParentView method.
PHPViewFactory::parseParentView
No response
The text was updated successfully, but these errors were encountered:
feat(templating,templating-bundle): make parse length for parent view…
2d3fe12
…s configurable Fix: snicco#171
This was not caused by the regex parsing.
It turns out that this happened due to the "Extends" keyword NOT being present in the first 100 bytes of the file contents.
Previously, we only searched the first 100 bytes. We now have this configurable with a default of 100 bytes.
Sorry, something went wrong.
7499eef
🎉 This issue has been resolved in version 1.5.0 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
No branches or pull requests
Thanks for taking the time to fill out this feature request!"
Which @snicco/* package(s) are relevant/related of the feature request?
templating
Description
Using the simple
PHPViewFactory
it is currently possible to extend a parent template by using the annotation.It would be nice to expand support to using doc-block annotations instead of only simple multi-line comments.
The first option works currently, the second one does not.
Proposed solution
We would need to change the regex parsing in the
PHPViewFactory::parseParentView
method.Alternatives
No response
The text was updated successfully, but these errors were encountered: