Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

snickers server is not using config.json PORT on http server #110

Closed
flavioribeiro opened this issue Aug 23, 2016 · 1 comment · Fixed by #132
Closed

snickers server is not using config.json PORT on http server #110

flavioribeiro opened this issue Aug 23, 2016 · 1 comment · Fixed by #132
Labels
bug easy
Milestone
Snickers 0.3

Comments

@flavioribeiro
Copy link
Member

refs https://github.com/snickers/snickers/blob/master/main.go#L19
@blainsmith
Copy link
Contributor

What are your thoughts on doing configurations this way instead of with a file? https://12factor.net

@flavioribeiro flavioribeiro changed the title Snickers Server is not using config.json PORT on http server snickers server is not using config.json PORT on http server Oct 10, 2016
@flavioribeiro flavioribeiro modified the milestone: Snickers 0.3 Oct 15, 2016
@dayvson dayvson mentioned this issue Oct 20, 2016
Merged
flavioribeiro added a commit that referenced this issue Oct 20, 2016
@flavioribeiro
Merge pull request #132 from snickers/FFMPEG_encoder
306b2ce 
Ffmpeg encoder refactor and snickers server using PORT via config.json (resolves #110, #123, #124)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug easy
Projects
None yet
Milestone
Snickers 0.3
2 participants
@flavioribeiro @blainsmith