Hydro 32bit PC #31
Merged
Hydro 32bit PC #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to fix 32bit alignment error in Eigen related code by using the Eigen::aligned_allocator in all STL Containers with Eigen. See these resources for more information than I understand: * http://eigen.tuxfamily.org/dox-devel/group__TopicStlContainers.html * (Cause 2:) http://eigen.tuxfamily.org/dox-devel/group__TopicUnalignedArrayAssert.html Note: This is not a completely informed fix ... it just seemed to finally fix the alignment error and make the program not crash on 32-bit 12.04 with groovy (no kinect).
There were errors during a clean-build after the Eigen alignment 32-bit fix from commit: e4dd950 in PR sniekum#17 Mostly the errors were from changes in the allocator of types in function calls/members of lower-level classes caused "no matching function" errors. This commit is a first pass attempt to fix these build errors from a clean build. Further detail should be looked into for the impact of these changes and the structure of the code.
Includes wrappers around STL containers in kinect related code, originally skipped in first 32bit fix. Also one change from a boost::make_shared<ARCloud> call that was causing assertions, to using the ARCloud::Ptr style. Conflicts: nodes/IndividualMarkers.cpp Decided to use all include files.(wyasuda)
|
+1; Looks good to me - all the changes included and nothing extra. Nice job figuring out the git commit magic =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only checked individualMarkersNoKinect running properly on my Ubuntu12.04LTS, Hydro 32bit PC.