Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: Allow a fixed suffix on invite links (e.g. /show) to avoid issues with URL highlighters which do not extend to _ or - #48

Closed
horazont opened this issue Feb 1, 2021 · 1 comment
Closed

UX: Allow a fixed suffix on invite links (e.g. /show) to avoid issues with URL highlighters which do not extend to _ or - #48

horazont opened this issue Feb 1, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone
0.1.1

Comments

@horazont
Copy link
Collaborator

horazont commented Feb 1, 2021

I had an invite code which ended with _ and a recipient was unable to tap it because the URL highlighter did not include the _ in the link. To fight that, we should add a suffix (like /show) to the path in the web portal.

To not break existing links, we should redirect from the bare invite to the /show URL inside the portal.
@horazont horazont added the enhancement New feature or request label Feb 1, 2021
@horazont horazont added this to the 0.1.1 milestone Feb 1, 2021
@horazont
Copy link
Collaborator Author

horazont commented Feb 3, 2021

We now allow / as suffix.

horazont added a commit to horazont/snikket-server that referenced this issue Feb 3, 2021
@horazont
Add / to invite URL
682fba8 
The new portal version will support this (see [1]). The rationale
is also explained over there, but to summarize: If the link ends
in `_` or `-`, some user agents will not linkify it correctly,
worsening the UX.

   [1]: snikket-im/snikket-web-portal#48
horazont added a commit to horazont/snikket-server that referenced this issue Feb 3, 2021
@horazont
Add / to invite URL
215426c 
The new portal version will support this (see [1]). The rationale
is also explained over there, but to summarize: If the link ends
in `_` or `-`, some user agents will not linkify it correctly,
worsening the UX.

   [1]: snikket-im/snikket-web-portal#48
@horazont horazont mentioned this issue Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.1
Development

No branches or pull requests
1 participant
@horazont