API customfields "required" field of different type when reported by fieldsets #11093
Closed
2 tasks done
Labels
✋ bug
Confirmed bug
Comments
snipe
added a commit
that referenced
this issue
Jun 7, 2022
…stom_fields_fieldsets Fixed #11093 - Return true/false for custom fields/fieldsets required value in API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Debug mode
Describe the bug
When performing a get on
/api/v1/fieldsets/Xyou also get the customfields as retrieved byapi/v1/fields/Y.The "required" field is obviously from a different source/meaning, but, the type is different.
Customfields report their value as
true/falsewhile the same data structure in field sets is reported as 0/1.Reproduction steps
Expected behavior
Both systems use the same data type to indicate whether a field is required or not. This allows to simplify de-serialization and data types drastically and prevents confusion.
Screenshots
Fieldset report
Requesting the fields entry
Snipe-IT Version
5.4.3
Operating System
Debian
Web Server
Apache
PHP Version
7.4
Operating System
No response
Browser
No response
Version
No response
Device
No response
Operating System
No response
Browser
No response
Version
No response
Error messages
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: