Asset Maintenance type "PAT Test" text is hard-coded, no translation

[rnelsonee]

Debug mode

• I have enabled debug mode
• I have read checked the Common Issues page

Describe the bug

The source code to generate lists of maintenances (getImprovementOptions function) has one option -- 'PAT Test' -- hard-coded rather than using the translation provided by localization options.

Reproduction steps

1. Navigate file browser to resources/lang/es-MX/admin/asset_maintenances/general.php
2. Change 'PAT Test' to 'PAT prueba' on line 15
3. Save file
4. Go to Snipe-it admin settings in your browser
5. Go to Localization and set language to "Spanish, Mexico"
6. Go to an Asset in Snipe-it
7. Click on Maintenances tab
8. Note that one option is still "PAT Test"

Expected behavior

The option should show "PAT prueba"

Screenshots

This shows the code that causes this bug

Snipe-IT Version

6.0.10

Operating System

Ubuntu

Web Server

Apache

PHP Version

8.1.9

Operating System

No response

Browser

No response

Version

No response

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

The bug is caused by an error in app/Models/AssetMaintenance.php where "PAT Test" is hard-coded in English. So any future translations will not work.

We need to change

    public static function getImprovementOptions()
    {
        return [
            trans('admin/asset_maintenances/general.maintenance') => trans('admin/asset_maintenances/general.maintenance'),
            trans('admin/asset_maintenances/general.repair')      => trans('admin/asset_maintenances/general.repair'),
            trans('admin/asset_maintenances/general.upgrade')     => trans('admin/asset_maintenances/general.upgrade'),
            'PAT test'      => 'PAT test',
            trans('admin/asset_maintenances/general.calibration')     => trans('admin/asset_maintenances/general.calibration'),

to

    public static function getImprovementOptions()
    {
        return [
            trans('admin/asset_maintenances/general.maintenance') => trans('admin/asset_maintenances/general.maintenance'),
            trans('admin/asset_maintenances/general.repair')      => trans('admin/asset_maintenances/general.repair'),
            trans('admin/asset_maintenances/general.upgrade')     => trans('admin/asset_maintenances/general.upgrade'),
            trans('admin/asset_maintenances/general.pat_test')     => trans('admin/asset_maintenances/general.pat_test'),
            trans('admin/asset_maintenances/general.calibration')     => trans('admin/asset_maintenances/general.calibration'),

Other context, this is my first bug report on Github. And if this bug is given a number, I'll attempt a PR to fix it.

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.