Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add sort function on column "groups" and "2fa active" in users view #12356

Closed
floschoepfer opened this issue Jan 16, 2023 · 2 comments
Assignees

Comments

@floschoepfer
Copy link
Contributor

Is your feature request related to a problem? Please describe.

You can't sort for the column "groups" in the users view.
image

You can't sort for the column "2fa active" in the users view.
image

Describe the solution you'd like

A sort function like all the other columns have.
image

Describe alternatives you've considered

No response

Additional context

Or is there a reason, that you can't sort for these columns?

@snipe
Copy link
Owner

snipe commented Jan 17, 2023

Sorting by group can get a little confusing, since a user could belong to multiple groups - so which are we ordering by? The 2FA sort is easily fixed though - I'll have a patch out shortly.

snipe added a commit that referenced this issue Jan 18, 2023
BREAKING: Partial fix for #12356: Make 2FA sortable in user list
@floschoepfer
Copy link
Contributor Author

Sorting by group can get a little confusing, since a user could belong to multiple groups - so which are we ordering by?

Never thought about that... You could sort for the group IDs, for example, if the user is in two groups, he's only sorted by the first group (the group with the lower ID).
I came up with this issue, because I wanted to sort for the groups to find out, which users are in no group.
But I see your point, and I'm totally fine, if there's no sort on the groups column.

@snipe snipe closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants