Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug With Passwords Including Ampersands? #12362

Closed
2 tasks done
corydlamb opened this issue Jan 17, 2023 · 5 comments · Fixed by #12363
Closed
2 tasks done

Bug With Passwords Including Ampersands? #12362

corydlamb opened this issue Jan 17, 2023 · 5 comments · Fixed by #12363

Comments

@corydlamb
Copy link
Contributor

corydlamb commented Jan 17, 2023

Debug mode

Describe the bug

Hello, loving Snipe thus far, however. I believe I may have accidentally found a bug involving passwords with ampersands and the auto generated email sent to users with credentials. I sent a user this automated email and the part of the password with the & also had amp; appended after the & (So, for example, instead of the password being "d57J08]& 'amp;' Sajb9VI" it was "d57J08]&Sajb9VI"). I'm assuming this may be an issue with the HTML used in email? Or would it be something on my end?

Reproduction steps

  1. Create user with password including a & character.
  2. Send user credential email.
  3. Observe "amp;" getting appended after the &.

Expected behavior

Expected Password without the "amp;" as removing that portion of text fixes the issue.

Screenshots

pass test

Snipe-IT Version

v6.0.14 build 9038

Operating System

Turnkey Linux

Web Server

Apache 2.4.38

PHP Version

8.1.11

Operating System

Windows

Browser

Google Chrome

Version

109.0.5414.74 (64 bit)

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

No response

@welcome
Copy link

welcome bot commented Jan 17, 2023

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@corydlamb
Copy link
Contributor Author

Hey, found a fix for this, going to see about submitting a pull request.

@uberbrady
Copy link
Collaborator

That'd be awesome, thank you!

@corydlamb
Copy link
Contributor Author

Created a pull request at #12363 let me know if I need to add anything. Nothing major so idk if you need me to do all of the stuff but if it must be done I'd be glad to :D @uberbrady

snipe added a commit that referenced this issue Jan 18, 2023
Fixed #12362: Bug With Passwords Including Ampersands?
@snipe
Copy link
Owner

snipe commented Jan 18, 2023

Merged, ty!

@snipe snipe closed this as completed Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants