Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not duplicate license #12918

Closed
2 tasks done
CrtiUser opened this issue Apr 26, 2023 · 2 comments · Fixed by #12922
Closed
2 tasks done

Can not duplicate license #12918

CrtiUser opened this issue Apr 26, 2023 · 2 comments · Fixed by #12922

Comments

@CrtiUser
Copy link

Debug mode

Describe the bug

When editing a license there seems to be an error with the right hand shown option for dublicating the license.
In my German localization there is a button saying "Lizenz duplizieren" (duplicate license).

The dupication does not work, with the error message "Der Standort ist nicht vorhanden" (location does not exist)
This might be due to the fact that the called URL is "http://MYHOST/locations/634/clone"

Reproduction steps

  1. Edit license
  2. Click on the right hand side on "Clone"
    ...

Expected behavior

License editor should open with a cloned license

Screenshots

No response

Snipe-IT Version

6.1.0

Operating System

Ubuntu 22.04 lTS

Web Server

Apache

PHP Version

7.4.3

Operating System

Windows

Browser

Edge

Version

No response

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

No response

@CrtiUser
Copy link
Author

Additonally I'm noticed that these "button" for the actions only appear in the license menu. In the Asset menu is still the pulldown menu for the actions visible. Is this configurable?

snipe added a commit that referenced this issue Apr 26, 2023
Signed-off-by: snipe <snipe@snipe.net>
snipe added a commit that referenced this issue Apr 26, 2023
…_locations

Fixed #12918 - wrong route for clone location
@snipe
Copy link
Owner

snipe commented Apr 26, 2023

This should be fixed now - thanks for the heads up.

The button view is coming to assets soon.

DarthKillian added a commit to DarthKillian/eti-assets that referenced this issue May 23, 2023
* new request, preparing support_url for validation

* Ensure users editing themselves do not deactivate their account

* fix: upgrade webpack from 5.76.2 to 5.77.0

Snyk has created this PR to upgrade webpack from 5.76.2 to 5.77.0.

See this package in npm:
https://www.npmjs.com/package/webpack

See this project in Snyk:
https://app.snyk.io/org/snipe/project/3d53e1dd-b8bf-46b5-ba61-18ce26933166?utm_source=github&utm_medium=referral&page=upgrade-pr

* fix: upgrade bootstrap-table from 1.21.3 to 1.21.4

Snyk has created this PR to upgrade bootstrap-table from 1.21.3 to 1.21.4.

See this package in npm:
https://www.npmjs.com/package/bootstrap-table

See this project in Snyk:
https://app.snyk.io/org/snipe/project/3d53e1dd-b8bf-46b5-ba61-18ce26933166?utm_source=github&utm_medium=referral&page=upgrade-pr

* add ARM64 architecture

* Regex added for link instead

* Fix operator in where clause

* Added more granular permissions on bulk actions for assets

Signed-off-by: snipe <snipe@snipe.net>

* Added permission on restore

Signed-off-by: snipe <snipe@snipe.net>

* remove space

* remove space

* added ldap_location to settings

* removed a typo

* Change from a standard Eloquent mapping for ID to a custom setRead

* Use superuser instead of admin state

* Added `auto_add_to_fieldsets` field

Signed-off-by: snipe <snipe@snipe.net>

* Added new strings

Signed-off-by: snipe <snipe@snipe.net>

* Fixed slightly weird padding

Signed-off-by: snipe <snipe@snipe.net>

* We don’t actually use this test?

Signed-off-by: snipe <snipe@snipe.net>

* Added new field to factory

Signed-off-by: snipe <snipe@snipe.net>

* Changed layout, added fieldsets

Signed-off-by: snipe <snipe@snipe.net>

* Added auto_add_to_fieldsets to API response

Signed-off-by: snipe <snipe@snipe.net>

* Updated redirect return

Signed-off-by: snipe <snipe@snipe.net>

* Added logic for syncing fieldset info

Signed-off-by: snipe <snipe@snipe.net>

* Added fieldset sync

Signed-off-by: snipe <snipe@snipe.net>

* Added a check to fail validation if the associated fieldsets are not value

Signed-off-by: snipe <snipe@snipe.net>

* Updated the sync to disassociate if all boxed are unchecked

Signed-off-by: snipe <snipe@snipe.net>

* Small refactor of HTML, added top submit button

Signed-off-by: snipe <snipe@snipe.net>

* Updated js packages

Signed-off-by: snipe <snipe@snipe.net>

* Updated dev assets

Signed-off-by: snipe <snipe@snipe.net>

* Add @dboth as a contributor

* Add @zacharyfleck as a contributor

* Applies snipe#12868

Signed-off-by: snipe <snipe@snipe.net>

* Fixed snipe#12918 - wrong toite for clone location

Signed-off-by: snipe <snipe@snipe.net>

* remove regex, add in starts_with

* Env-ify hashing variables, setting the normal defaults

Signed-off-by: snipe <snipe@snipe.net>

* requested edits

* Use the asset tag instead of asset name if no name is given

Signed-off-by: snipe <snipe@snipe.net>

* Added help text to the now-dynamic manufacturer URLS

Signed-off-by: snipe <snipe@snipe.net>

* Added dynamic warranty URL to manufacturers

Signed-off-by: snipe <snipe@snipe.net>

* Switch back to “normal” url for support

Signed-off-by: snipe <snipe@snipe.net>

* Remove auto-link from from manufacturer warranty

Signed-off-by: snipe <snipe@snipe.net>

* Removed SR text for exporting

Signed-off-by: snipe <snipe@snipe.net>

* Fixed translation

Signed-off-by: snipe <snipe@snipe.net>

* Switch to externalLinkFormatter

Signed-off-by: snipe <snipe@snipe.net>

* requested edits

* Added missing case for licenses for item_count

Signed-off-by: snipe <snipe@snipe.net>

* Remove the loading of asset maintenances that are not used by view

* Eager load default locations

* Fixed  snipe#12946 - warranty lookup url was not nullable

Signed-off-by: snipe <snipe@snipe.net>

* Moved external link icon into link

Signed-off-by: snipe <snipe@snipe.net>

* Added tooltip

Signed-off-by: snipe <snipe@snipe.net>

* Added nobr tag to prevent external link icon and link from breaking

Signed-off-by: snipe <snipe@snipe.net>

* Check if model exists before create asset via API

* Prevent hard fail when retrieving acceptance data

* Clear the settings cache on app destruction

* Add InteractsWithSettings trait to required tests

* Improve method name

* fixes dark yellow

* adds fixes to dark black theme

* Restrict PHP to >=7.4.3 <8.2

* fixes dark green theme

* fixes dark orange theme

* fixes dark blue and btn-warning bg

* fixes dark red

* removed dead space

* corrections for dark red

* moar changes to red

* Snyk webpack upgrade

Signed-off-by: snipe <snipe@snipe.net>

* Updated dev assets

Signed-off-by: snipe <snipe@snipe.net>

* Use translation string

Signed-off-by: snipe <snipe@snipe.net>

* Unmix return type variables

Signed-off-by: snipe <snipe@snipe.net>

* buttons added

* Buttons on the accessory view page

* Buttons on the accessory view page

* Bumped version to 6.1.1-pre

Signed-off-by: snipe <snipe@snipe.net>

* Add CheckoutAcceptance factory

* Include user's name in Acceptance result notifications for accessories

* Capitalize "declined" in acceptance in notification

* Add additional information to acceptance notifications for assets, accessories, and consumables

* Restore the 'Asset Notes' and 'Model Notes' in the Map Asset Import Fields form

* Tweak 'exist' rule in Asset->model_id field so it ignores soft-deleted models

* Show signature column regardless of “require sig” state

Signed-off-by: snipe <snipe@snipe.net>

* Added missing use statement

Signed-off-by: snipe <snipe@snipe.net>

* Fixed misplaced div when saml is disabled

Signed-off-by: snipe <snipe@snipe.net>

* Add optional filename to backup

Signed-off-by: snipe <snipe@snipe.net>

* Check that the filename we pass ends in zip, add it if not

Signed-off-by: snipe <snipe@snipe.net>

* Make validation match database fields

Signed-off-by: snipe <snipe@snipe.net>

* Migration to embiggen state fields

Signed-off-by: snipe <snipe@snipe.net>

* Added maxlenth to form fields

Signed-off-by: snipe <snipe@snipe.net>

* Pass filename to pre-import backup

Signed-off-by: snipe <snipe@snipe.net>

* Pass filename for manual backups

Signed-off-by: snipe <snipe@snipe.net>

* Removed whitespace

Signed-off-by: snipe <snipe@snipe.net>

* Add ejected pipeline configuration for ChipperCI

* Configure Dusk for ChipperCI

* Limit ChipperCI to running on push to master or develop

* Fixed width of columns in details

Signed-off-by: snipe <snipe@snipe.net>

* Added icon field back into assets page

Signed-off-by: snipe <snipe@snipe.net>

* Made spacing more compact

Signed-off-by: snipe <snipe@snipe.net>

* Tightened up some layout issues, checkbox issues in LDAP settings

Signed-off-by: snipe <snipe@snipe.net>

* Google oauth login

Signed-off-by: snipe <snipe@snipe.net>

* Added migration

Signed-off-by: snipe <snipe@snipe.net>

* Removed env dependency, switched to DB

Signed-off-by: snipe <snipe@snipe.net>

* Add validation and fillable fields

Signed-off-by: snipe <snipe@snipe.net>

* Added settings routes for google auth

Signed-off-by: snipe <snipe@snipe.net>

* Changed redirect

Signed-off-by: snipe <snipe@snipe.net>

* Added methods for google settings

Signed-off-by: snipe <snipe@snipe.net>

* Removed redirect option

Signed-off-by: snipe <snipe@snipe.net>

* Added google option to settings index

Signed-off-by: snipe <snipe@snipe.net>

* Added google settings blade

Signed-off-by: snipe <snipe@snipe.net>

* Pulled redirect from settings

Signed-off-by: snipe <snipe@snipe.net>

* Use google logo

Signed-off-by: snipe <snipe@snipe.net>

* Disabled fields in demo mode

Signed-off-by: snipe <snipe@snipe.net>

* Very ugly login shim just to test functionality

Signed-off-by: snipe <snipe@snipe.net>

* Disallow saving data if app is locked

Signed-off-by: snipe <snipe@snipe.net>

* Create constructor to override expected config variables

Signed-off-by: snipe <snipe@snipe.net>

* Added debugging

Signed-off-by: snipe <snipe@snipe.net>

* Switch to using username as match for google login

Signed-off-by: snipe <snipe@snipe.net>

* Remove avatar update, since we don’t take URLs for that

Signed-off-by: snipe <snipe@snipe.net>

* Use normal translation style

Signed-off-by: snipe <snipe@snipe.net>

* Clearer comments

Signed-off-by: snipe <snipe@snipe.net>

* Re-add the image update

Signed-off-by: snipe <snipe@snipe.net>

* Check for http or https in avatar value

Signed-off-by: snipe <snipe@snipe.net>

* Added translation string for google auth failure

Signed-off-by: snipe <snipe@snipe.net>

* Hide client secret if app is locked

Signed-off-by: snipe <snipe@snipe.net>

* Nicer button

Signed-off-by: snipe <snipe@snipe.net>

* Added validation on google client ID

Signed-off-by: snipe <snipe@snipe.net>

* Added ends_with validation message

Signed-off-by: snipe <snipe@snipe.net>

* Added translations

Signed-off-by: snipe <snipe@snipe.net>

* Few more login page tweaks

Signed-off-by: snipe <snipe@snipe.net>

* Final google login tweaks

Signed-off-by: snipe <snipe@snipe.net>

* I lied. Missed one

Signed-off-by: snipe <snipe@snipe.net>

* Extra debugging

Signed-off-by: snipe <snipe@snipe.net>

* Added Google test user

Signed-off-by: snipe <snipe@snipe.net>

* Bumped hash

Signed-off-by: snipe <snipe@snipe.net>

* Disable browser tests in ChipperCI

* Updated webpack, new asset files

Signed-off-by: snipe <snipe@snipe.net>

* Production assets

Signed-off-by: snipe <snipe@snipe.net>

* Add @vikaas-cyper as a contributor

* Used brackets for multiselect company

Signed-off-by: snipe <snipe@snipe.net>

* Fixed multiselect for companies

Signed-off-by: snipe <snipe@snipe.net>

* Wrong eval

Signed-off-by: snipe <snipe@snipe.net>

* Added multi-select option to custom report

Signed-off-by: snipe <snipe@snipe.net>

* standardizes the importer colors no matter the theme

* adds translation to checkout notification

* removes assigned_to if archived

* Additional multi-select options for custom report

Signed-off-by: snipe <snipe@snipe.net>

* Use actions text in backups table

Signed-off-by: snipe <snipe@snipe.net>

* Importer fix for non-Location imports

* Updated dev assets

Signed-off-by: snipe <snipe@snipe.net>

* Added EOL date to importer

Signed-off-by: snipe <snipe@snipe.net>

---------

Signed-off-by: snipe <snipe@snipe.net>
Co-authored-by: akemidx <kojotek.dx@gmail.com>
Co-authored-by: Marcus Moore <contact@marcusmoore.io>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: snipe <snipe@snipe.net>
Co-authored-by: zacharyfleck <zfleck@clinetic.com>
Co-authored-by: Zachary Fleck <87536651+zacharyfleck@users.noreply.github.com>
Co-authored-by: Godfrey M <godmartinz@gmail.com>
Co-authored-by: Brady Wetherington <bwetherington@grokability.com>
Co-authored-by: Ivan Nieto Vivanco <inietov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants