[Feature Request]: View PDF files inside browser instead of downloading #13562
Comments
|
We used to have them display online and people complained about that. |
DarthKillian
added a commit
to DarthKillian/eti-assets
that referenced
this issue
Sep 28, 2023
* Added name order to settings save controller method Signed-off-by: snipe <snipe@snipe.net> * Switch to getFullNameAttribute() in user transformer Signed-off-by: snipe <snipe@snipe.net> * Removed getCompleteNameAttribute(), modified getFullNameAttribute() Signed-off-by: snipe <snipe@snipe.net> * New strings Signed-off-by: snipe <snipe@snipe.net> * Changed width of locale field Signed-off-by: snipe <snipe@snipe.net> * Added form macro for name format Signed-off-by: snipe <snipe@snipe.net> * Switched to getFullNameAttribute() from fullName() in User Presenter Signed-off-by: snipe <snipe@snipe.net> * Added name display format, tweaked some Signed-off-by: snipe <snipe@snipe.net> * Tweak layout Signed-off-by: snipe <snipe@snipe.net> * Switched from fullName() to getFullNameAttribute() Signed-off-by: snipe <snipe@snipe.net> * Add simple tests around asset check in * adds id to history info * adds some spacing * Add last checkin options to report front end * Default to using the current date if last check in end date is not provided * Bump nyholm/psr7 to 1.6.1 * Bump guzzlehttp/psr7 to 2.4.5 * Removed unused translation Signed-off-by: snipe <snipe@snipe.net> * Small fixes to checkbox layout in general settings blade Signed-off-by: snipe <snipe@snipe.net> * removes encrypted info from change log, renames asset_eol_date in the change log * eager loaded changedInfo queries, reworked encrypted data change log changes * retarget key * removed dead space * Add withTrashed to asset model query * Remove trans() from default values Signed-off-by: snipe <snipe@snipe.net> * adds soft deletes to eager loading * adds soft deletes to eager loading * fixes conflicts * Add condition in LicenseCheckinController:bulkCheckin method to evaluate if the license is reassignable * Disable the Checkin All Seats button if License is not reassignable * Run tests for PHP 7.4, 8.0, and 8.1.1 * Explicitly declare $clean_meta variable * Clear commented log statements * adds min_amt to asset model edit, index, and table * fixing my mess * fix conflicts * working on getting notifications * Adds readable asset history in the action log transformer * adds id to history info * adds some spacing * revert unwanted changes * revert changes of composer.lock * removed unnecessary code * fixed lost changes * Added a condition to send correct model id when cloning one * Add a variable so I dont ended rewriting the original model * Added link to the help docs Signed-off-by: snipe <snipe@snipe.net> * Tighter layout Signed-off-by: snipe <snipe@snipe.net> * Fixed snipe#13521 - make modal “select files” button wider Signed-off-by: snipe <snipe@snipe.net> * Try to prevent the browser from pre-filling the LDAP password Signed-off-by: snipe <snipe@snipe.net> * Use int not string if no DB_PORT specified Signed-off-by: snipe <snipe@snipe.net> * Removed stray line Signed-off-by: snipe <snipe@snipe.net> * Set password property properly Signed-off-by: snipe <snipe@snipe.net> * Reverse orderof parent Signed-off-by: snipe <snipe@snipe.net> * Pass the model_id variable in the controller and get it only if we are cloning the asset model * reworks company queries for asset history * Add failing test * Ensure users are scoped by company in index method * Bumped hash Signed-off-by: snipe <snipe@snipe.net> * Upgrade less from 4.1.2 to 4.2.0 snipe#13534 Signed-off-by: snipe <snipe@snipe.net> * Upgrade @fortawesome/fontawesome-free from 6.4.0 to 6.4.2 snipe#13527 Signed-off-by: snipe <snipe@snipe.net> * Updated assets Signed-off-by: snipe <snipe@snipe.net> * Fixed bug introduced in snipe#13528 Signed-off-by: snipe <snipe@snipe.net> * Fixed bug introduced in snipe#13528 Signed-off-by: snipe <snipe@snipe.net> * Don’t cast as boolean, validate as boolean Signed-off-by: snipe <snipe@snipe.net> * Update assertions to account for type change * Early return if no asset is found * Adds a null coalescing operator to the license seat checkin notification * Added tests Signed-off-by: snipe <snipe@snipe.net> * Un-cast byod, validate as boolean Signed-off-by: snipe <snipe@snipe.net> * Update testing documentation * Remove Dusk * Add failing test * Scaffold tests and add context * Added model name and number to dynamic url Signed-off-by: snipe <snipe@snipe.net> * Track changes on asset checkin/out * Account for hard-deleted models, suppliers Signed-off-by: snipe <snipe@snipe.net> * Use same method of accessing companies as others Signed-off-by: snipe <snipe@snipe.net> * Removed soft-delete query Signed-off-by: snipe <snipe@snipe.net> * Fixed snipe#13562 - allow inline view for uploaded files Signed-off-by: snipe <snipe@snipe.net> * Added inline=true to image preview modal Signed-off-by: snipe <snipe@snipe.net> * Move the early return to the controller instead of the Label model * Add rtd_location_id to tracked changes on checkin actionlog * Add guard clauses around some License and LicenseSeat models functions * Begin to implement patch test * Upgrade to new branch for our fork of laravel-scim-server * Update to only use relative paths Signed-off-by: snipe <snipe@snipe.net> * Implement test case * Filter unaccepted assets that are not assigned to users * Formatting * Remove unused test cases * Test permissions update * Relax property type check * Remove todo * Update assertion and add failure messages * Upgraded actions/checkout to v4 (via snipe#13580) Signed-off-by: snipe <snipe@snipe.net> * removes commented code * Add a boolean variable and condition to handle the call to checkedOutToUser() method * Guard against attempting to send notification to model that isn't notifiable * fixed nullability of on Asset Models * changed the down method change * Reset assigned_x values when changing check out to type * Evaluate if the event properties exists before run the CheckoutAcceptance query * Use $attributes array Signed-off-by: snipe <snipe@snipe.net> * Fixed checkbox formatting on quickstart Signed-off-by: snipe <snipe@snipe.net> * Removed stray text Signed-off-by: snipe <snipe@snipe.net> * Remove ChipperCI * Simplify upload messaging Signed-off-by: snipe <snipe@snipe.net> * Fixed import error warning Signed-off-by: snipe <snipe@snipe.net> * Revert large warning size Signed-off-by: snipe <snipe@snipe.net> * Typo Signed-off-by: snipe <snipe@snipe.net> * Removed stray space Signed-off-by: snipe <snipe@snipe.net> * Fixed snipe#13592 - unable to delete model from view page Signed-off-by: snipe <snipe@snipe.net> * Bumped hash Signed-off-by: snipe <snipe@snipe.net> * Use relative path in backups for cleaner directory structure Signed-off-by: snipe <snipe@snipe.net> * Fixes snipe#13609 - disallow sorting on age Signed-off-by: snipe <snipe@snipe.net> * Fixed regression that disabled sticky headers Signed-off-by: snipe <snipe@snipe.net> * Added column re-ordering Signed-off-by: snipe <snipe@snipe.net> * Made develop the target branch Signed-off-by: snipe <snipe@snipe.net> * Bump docker/login-action from 2 to 3 (snipe#13619) Signed-off-by: snipe <snipe@snipe.net> * Bump docker/build-push-action from 4 to 5 Signed-off-by: snipe <snipe@snipe.net> * Replaces snipe#13617 - Bump docker/setup-buildx-action from 2 to 3 Signed-off-by: snipe <snipe@snipe.net> * Replaces snipe#13616 - Bump docker/metadata-action from 4 to 5 Signed-off-by: snipe <snipe@snipe.net> * Updated assets Signed-off-by: snipe <snipe@snipe.net> * Fixed snipe#13628 - removed duplicate favicon tag Signed-off-by: snipe <snipe@snipe.net> * Add factories to autolabeler action * Add unique() to some factory properties * Display error message if import file deleted before it can be selected * Remove unnecessary redirect * Added some mail settings to /settings for easier reference Signed-off-by: snipe <snipe@snipe.net> * Added Khmer as an available language Signed-off-by: snipe <snipe@snipe.net> * Added new translations Signed-off-by: snipe <snipe@snipe.net> * Bumped version Signed-off-by: snipe <snipe@snipe.net> * A few more config options Signed-off-by: snipe <snipe@snipe.net> * Fixed table Signed-off-by: snipe <snipe@snipe.net> * Check for null company ID Signed-off-by: snipe <snipe@snipe.net> * Fixed typo Signed-off-by: snipe <snipe@snipe.net> * Commented out sortable columns Signed-off-by: snipe <snipe@snipe.net> * Fix default.blade.php Signed-off-by: Darth Killian <rhuntington719@gmail.com> * Fix AssetCheckoutController (missing bracket) Signed-off-by: Darth Killian <rhuntington719@gmail.com> * Fix AssetCheckoutController (again) Signed-off-by: Darth Killian <rhuntington719@gmail.com> * Abandoning trying to fix checkout controller... Reset checkout controller to what I know works until I can find a nice way to merge changes from snipe it Signed-off-by: Darth Killian <rhuntington719@gmail.com> * Update composer packages Signed-off-by: Darth Killian <rhuntington719@gmail.com> --------- Signed-off-by: snipe <snipe@snipe.net> Signed-off-by: Darth Killian <rhuntington719@gmail.com> Co-authored-by: snipe <snipe@snipe.net> Co-authored-by: Marcus Moore <contact@marcusmoore.io> Co-authored-by: Godfrey M <godmartinz@gmail.com> Co-authored-by: Godfrey Martinez <47435081+Godmartinz@users.noreply.github.com> Co-authored-by: Ivan Nieto Vivanco <inietov@gmail.com> Co-authored-by: Johnson Yi <jyi.dev@outlook.com> Co-authored-by: johnson-yi <63399474+johnson-yi@users.noreply.github.com> Co-authored-by: Brady Wetherington <bwetherington@grokability.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
No its not. PDF files can be downloaded perfectly. However it will be convenient to have this feature.
Describe the solution you'd like
Similar to images, if there is a possibility of either viewing a PDF file in the same tab or a new one, would be a perfect solution.
Describe alternatives you've considered
None right now. I can only download and then view it.
Additional context
if I have to view I have to redownload a file which causes unessary downloading.
Similar to: #7055
The text was updated successfully, but these errors were encountered: