Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Clearing user requests #5080

Open
alden-david opened this issue Feb 22, 2018 · 64 comments
Open

Feature Request: Clearing user requests #5080

alden-david opened this issue Feb 22, 2018 · 64 comments
Labels
❤️ feature request 👩‍💻 ready for dev These issues are ready for someone to work on them - take your pick!

Comments

@alden-david
Copy link

alden-david commented Feb 22, 2018

Desired Behavior

It would be helpful to me for admins to be able to clear requests manually, or have them automatically cleared at checkout or checkin. For example:

  • User requests asset
  • Admin checks out asset to user
  • Request is cleared

Really any way for an admin to remove an individual request from /hardware/requested would be helpful for clearing stale requests without hunting down users.


Actual Behavior

  • User requests asset
  • Request remains until user cancels request regardless of fulfillment or admin actions

  • Snipe-IT v4.1.14 - build 3382 (master)
  • PHP v7.2.1
  • MariaDB v10.0
  • IIS 7.5

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jeffclay
Copy link
Contributor

On our system..
User requests asset.
Request is visible on the "Requested Assets" page.
Admin then clicks "Check Out" button next to the request and checks it out the user.
The "Requested Assets" page now shows a "Check In" button instead of "Check Out", signifying that the requested asset has been assigned.

@alden-david
Copy link
Author

Mine behaves that way also, but after using the "Check In" button it reverts back to "Check Out" and the request stays in place. I'd rather the request be removed so that the user could request it again, and the "Requested Assets" page isn't crowded with already-fulfilled requests that aren't marked that way.

@snipe snipe added 👩‍💻 ready for dev These issues are ready for someone to work on them - take your pick! ❤️ feature request labels Feb 22, 2018
@snipe
Copy link
Owner

snipe commented Feb 22, 2018

This is a good feature request - we'll try to get this into an upcoming release.

@stale
Copy link

stale bot commented May 5, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label May 5, 2018
@alden-david
Copy link
Author

Please don't close it, stale bot. This would still be a useful feature.

@stale stale bot removed the stale label May 7, 2018
@stale
Copy link

stale bot commented Jul 6, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Jul 6, 2018
@alden-david
Copy link
Author

I am still interested in this feature request.

@stale stale bot removed the stale label Jul 6, 2018
@stale
Copy link

stale bot commented Sep 4, 2018

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Sep 4, 2018
@alden-david
Copy link
Author

As of v4.6.4, there is still no way for administrators to clear requests. I am still interested in this functionality.

@stale
Copy link

stale bot commented Sep 4, 2018

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@stale stale bot removed the stale label Sep 4, 2018
@stale
Copy link

stale bot commented Nov 3, 2018

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Nov 3, 2018
@alden-david
Copy link
Author

As of v4.6.6, I still see no way for administrators to clear requests. I am still interested in this functionality.

@stale
Copy link

stale bot commented Nov 5, 2018

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@stale stale bot removed the stale label Nov 5, 2018
@duel007
Copy link

duel007 commented Jan 3, 2019

I am also interested in this feature.

@stale
Copy link

stale bot commented Mar 4, 2019

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Mar 4, 2019
@duel007
Copy link

duel007 commented Mar 5, 2019

I am still interested in this feature.

@stale
Copy link

stale bot commented Mar 5, 2019

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@stale stale bot removed the stale label Mar 5, 2019
@stale
Copy link

stale bot commented Jun 28, 2020

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@stale stale bot removed the stale label Jun 28, 2020
@KSpakes87
Copy link

Still interested

@caburum
Copy link

caburum commented Jun 30, 2020

I'll +1 this. I manage assets for a local club and it is annoying to track down people with stale requests.

@stale
Copy link

stale bot commented Aug 29, 2020

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Aug 29, 2020
@KSpakes87
Copy link

Still intereated

@stale
Copy link

stale bot commented Aug 29, 2020

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@stale stale bot removed the stale label Aug 29, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Dec 25, 2020
@KSpakes87
Copy link

Still interested

@stale
Copy link

stale bot commented Dec 25, 2020

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@dalyaaglan1984
Copy link

Still interested !

@hrconsultJP
Copy link

Very interested. Not sure why it’s not already implemented.

@stfloyd
Copy link

stfloyd commented Apr 7, 2021

If anyone is still interested, I have this feature partially implemented. You check it out @ stfloyd/snipe-it/feature/manage-requests

I have this running in production at work and it does the job.

I will submit a PR once I have translated the appropriate messages as right now I only have en-US and en-GB.

@hrconsultJP
Copy link

hrconsultJP commented May 10, 2021 via email

@jcookatlas
Copy link

Still waiting for this request to be included in an actual RELEASE build... NOT STALE

@KSpakes87
Copy link

Still interested as well

@stfloyd
Copy link

stfloyd commented Dec 1, 2021

@hrconsultJP & anyone else - sorry for the delay getting to you, I've been extremely busy with a new job and moving states (US). I have not had the time to put this all together, however most of the work is done it's just translations that need to be made. If I find time this next week or two I will see if I can pull and merge with latest and submit an official PR, but no guarantees.

Thanks,
Steven

@ct-martin
Copy link

Hello, we'd be interested in this as well. We had to resort to having our Senior IT person logging into and modifying the database directly to cancel requests, which is less than ideal and also not a sustainable solution.

@mw-christensen
Copy link

I am still interested in this. Honestly, I don't much see the usefulness of being able to request an item if an admin can't clear the request. Even after I checkout the item to the user and check it back in, it still shows as requested by the user. Basically the user has a hold on the item unless the user actually goes in and removes the request. Perhaps I am missing something?

@AlbertoSilva82
Copy link

Do we have this implemented? Thank you!

@deflower
Copy link

I'd like to see this implemented as well. I get the same results as mw-christensen. "Requests" and "checkouts" do not seem to be linked. After a requested item has been checked out, the original request for the user remains until the user cancels it. There is no UI or API call to cancel a request.

@hrconsultJP
Copy link

hrconsultJP commented Apr 13, 2023 via email

@mw-christensen
Copy link

It does seem a bit odd to me. I feel like it is a feature that has never worked as intended, which if this is the case I don't understand why it does not get fixed or removed.

If it does work as intended then how to people actually use this feature? I honestly can't see how the request feature is useful in the state it is in.

@Adventurer21
Copy link

Adventurer21 commented Aug 17, 2023

I'd like to also register my interest in this change.

The "request" feature is unusable if the request can't be cleared in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❤️ feature request 👩‍💻 ready for dev These issues are ready for someone to work on them - take your pick!
Projects
None yet
Development

No branches or pull requests