Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Add Department like Company field to Assets #8072

Open
circuitswitch opened this issue May 22, 2020 · 19 comments
Open

Request Add Department like Company field to Assets #8072

circuitswitch opened this issue May 22, 2020 · 19 comments

Comments

@circuitswitch
Copy link

Hi,

Thank-you for the product. It is so much better than so many other things.

One little request. Assets have Company, but don't have Department fields. I would really like to add Department rather than Company (or in addition) so I can show a group of people within a Company own a particular asset.

I realize I could make Company work by adding multiple more granular entries in Company, but since we have Departments linked to Companies, it would be nice to leverage that field.

Thank-you!

@circuitswitch
Copy link
Author

I forgot to mention, I see personnel have Department, but Assets do not. It would be nice to at least eyeball check that a person requesting an Asset actually belongs to the same Department as the Asset.

@bra1ncramp
Copy link

Currently Assets can be assigned to a company without being "Checked out". Unfortunately, there doesn't seem to be any hierarchy for Companies - which does not reflect the real world.

We need a way to account for assets that are designated for one department over another in a company.

Use case:
We buy 100 laptops. We have three companies (A,B, and C)

30 laptops are for Company A's marketing department
10 are for Company A's accounting department
20 are for Company B's IT department
20 are for Company B's marketing department
10 are for Company C's sales department
10 are for Company C's accounting department

I need to be able to assign to Company AND department. I need to be able to search for all assets for Company A (checked out and ready to deploy), but I may also want to just search for the specific department. Currently, there is no way to do this.

@twisted3motions
Copy link

Agreed

@sjackson0109
Copy link

I was discussing this very issue the other day.

@stale
Copy link

stale bot commented Dec 25, 2020

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Dec 25, 2020
@circuitswitch
Copy link
Author

circuitswitch commented Dec 25, 2020 via email

@stale
Copy link

stale bot commented Dec 25, 2020

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@stale stale bot removed the stale label Dec 25, 2020
@sjackson0109
Copy link

sjackson0109 commented Dec 26, 2020 via email

@circuitswitch
Copy link
Author

Thank-you

@eeintech
Copy link

Still relevant even now, any plan to support both companies and department?

Thanks 👍

@LeeReitz
Copy link

LeeReitz commented Mar 1, 2022

I would like to see this feature. I have noticed there are other feature request for department "checkout" which have been denied (understandably so). It would be appreciated if at first we can assign assets to a department and maybe later add some view filtering/permission to department. Similar to Company features.

@baghirani
Copy link

Very Important feature. And I have an addition to that:
Not only that an asset and all the other stuff should belong to a department. The departments should have a hierarchy. And it should be possible to assign permissions based on the hierarchy. Because a manager of a small group should be able to view and even edit the items of his group, but he should not be able to do this for the rest of the company.

@snipe
Copy link
Owner

snipe commented Mar 21, 2022

That's what Full Multiple Company Support is for. Just use Companies as Departments.

@eeintech
Copy link

That's what Full Multiple Company Support is for. Just use Companies as Departments.

Is the "Companies" model name modular and be renamed by admin? Mixin of words can be confusing so it could work if that was the case.

@LeeReitz
Copy link

According to the User Guides, Full Multiple Company Support is for multi-tenancy. Which won't satisfy all the cases we are discussing if data is properly segregated. The concepts of Company and Department are already exist in the application, we are asking for improvements on the department concept that imitates department structures in real life.

Several users have taken the time and asked several times for this feature. It appears Snipe being resistant to entertain the feature request, per responses to other requests. Is there system restraints that would cause this feature request to be unachievable or cause system issues? Is there other factors to consider? Would be considered if community developed?

@baghirani
Copy link

But you can't have a company hierarchy right? So it is not possible to set someone who can see the whole sub hierarchy. I have to create a big bunch of companies, that are not structured.
Doesn't make it sense to just combine departments and companies, let the administration decide how to name each level and to make it configurable if there is a manager which can view all sub departments?

@snipe
Copy link
Owner

snipe commented Mar 22, 2022

Is there system restraints that would cause this feature request to be unachievable or cause system issues? Is there other factors to consider? Would be considered if community developed?

System restraints, not exactly. It would require several database migrations to keep the functionality working as expected for most people.

I would likely not consider this if community developed. Building something is easy - maintaining it and securing it over time is a lot harder.

@baghirani
Copy link

Ok, I will try to put some stuff together, maybe there is a nice solution for some more issues, f.e. #(7359), #(8672), #(9621) and #(10347), I found, and I think there are some more.

  • Add a hierarchy to the department by adding a field for department and company. Maybe the same field for both, if possible?

  • Add a department to an Asset. Maybe the same field here as well, for selecting Company or Department? Because if we can select a department and a department belongs to a company it is still clear what belongs to a company.

  • Add a possibility to configure permissions depending on departments/companies. Just by adding a group which can be limited to a department.

For me this would definitely work, maybe for the others as well?

@snipe
Copy link
Owner

snipe commented Mar 22, 2022

I would likely not consider this if community developed

You're welcome to go down this path, but I did already say I probably wouldn't consider merging it.

Hierarchy sounds easy, but then you will run into recursion issues for counting the numbers of people, assets, etc within a department. How many levels of hierarchy should be allowed? How do you make sure a child-department is not its own parent? Validation alone become a hellscape. Right now, dept names must be unique - we'll need to change that to be unique to company+dept combo. And then testing and maintaining it down the line is a whole other thing.

The way you use (or want to use) Snipe-IT isn't the way a lot of people do. Believe it or not, I'm not reticent for new things, but as the steward of this project for 9+ years, I'm the one who will be left holding the bag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants