Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ch1405] asset redirect #10061

Conversation

Godmartinz
Copy link
Collaborator

adds a redirect checkbox for users to go back to the asset's page.
image

Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always want to be using the iCheck classes here - I believe you’ll want to add minimal, but I’m AFK so you can check the “remember me” checkbox on the login blade for the specific class. It should look larger and square, versus as a default checkbox.

Also I kinda feel like from a UI perspective, this option would make more sense in the box-footer, to the left of the submit button, but with distance from the cancel button.

We should also set a cookie or setting here so that people don’t have to check it every time. (They will complain about it, I promise.)

An alternate approach would be something like a select box in that footer that offers:

  • Return to Assets Listing
  • Go to Asset
  • Go to User/Location/Whatever

It would default to the default current behavior (return to asset), but if they select something different, we set a cookie and make sure the intentionally selected option is pre-selected. Basically we “remember” whatever their last choice was.

@snipe
Copy link
Owner

snipe commented Sep 8, 2021

(TYVM for the screenshots BTW - very helpful!)

@Godmartinz
Copy link
Collaborator Author

I like the cookie idea better. I'll get on it. May have questions though

@snipe
Copy link
Owner

snipe commented Sep 8, 2021

The cookie (Session::put(), really) needs to happen either way, but I think the select box in the box-footer option might be better, since it gives people more options. Only real danger is that when localized in a language that isn’t English, it might start to be too wide.

Logically, it makes more sense to have that decision be next to the submit button, versus part of the regular checkout business logic, IMHO.

@snipe
Copy link
Owner

snipe commented Sep 8, 2021

Something kinda like this:

Screen Shot 2021-09-08 at 4 54 47 PM

(Apologies for the roughness of it - as I mentioned I'm AFK)

@Godmartinz
Copy link
Collaborator Author

image

@snipe
Copy link
Owner

snipe commented Sep 11, 2021

That looks great - I don't see those changes in this PR tho? Maybe forgot to push?

@Godmartinz
Copy link
Collaborator Author

Yep forgot to push

@snipe
Copy link
Owner

snipe commented Sep 11, 2021

That’s a navigation menu drop down, not a select box tho (we’d want to use select2), and I don’t see the backend updated to handle the different choices.

@Godmartinz
Copy link
Collaborator Author

repushed, I'm not using Session::get/pull correctly..not sure why though. functionality for the redirects works now. The only thing is the default selected redirect option that sessions should populate..and the rounded corners of the dropbox.

@Godmartinz
Copy link
Collaborator Author

Woot! figured it out, updating and pushing now.

@snipe snipe deleted the branch snipe:develop-v6-integration September 26, 2021 20:37
@snipe snipe closed this Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants