-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ch1405] asset redirect #10061
[Ch1405] asset redirect #10061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We always want to be using the iCheck classes here - I believe you’ll want to add minimal
, but I’m AFK so you can check the “remember me” checkbox on the login blade for the specific class. It should look larger and square, versus as a default checkbox.
Also I kinda feel like from a UI perspective, this option would make more sense in the box-footer, to the left of the submit button, but with distance from the cancel button.
We should also set a cookie or setting here so that people don’t have to check it every time. (They will complain about it, I promise.)
An alternate approach would be something like a select box in that footer that offers:
- Return to Assets Listing
- Go to Asset
- Go to User/Location/Whatever
It would default to the default current behavior (return to asset), but if they select something different, we set a cookie and make sure the intentionally selected option is pre-selected. Basically we “remember” whatever their last choice was.
(TYVM for the screenshots BTW - very helpful!) |
I like the cookie idea better. I'll get on it. May have questions though |
The cookie ( Logically, it makes more sense to have that decision be next to the submit button, versus part of the regular checkout business logic, IMHO. |
That looks great - I don't see those changes in this PR tho? Maybe forgot to push? |
Yep forgot to push |
That’s a navigation menu drop down, not a select box tho (we’d want to use select2), and I don’t see the backend updated to handle the different choices. |
repushed, I'm not using Session::get/pull correctly..not sure why though. functionality for the redirects works now. The only thing is the default selected redirect option that sessions should populate..and the rounded corners of the dropbox. |
Woot! figured it out, updating and pushing now. |
adds a redirect checkbox for users to go back to the asset's page.
![image](https://user-images.githubusercontent.com/47435081/132598235-82cc2107-de75-43f2-a389-08ccea72da71.png)