Upgrade Docker to PHP 7.4 #10080
Merged
Upgrade Docker to PHP 7.4 #10080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving our Docker environment to a later version of PHP is going to be a requirement for Snipe-IT v6. The current v5 uses PHP 7.2, which is too old for Snipe-IT v6. I could've put this change on our v6 integration branch, but I feel like the benefits to the v5 users are too great to make our current v5 users wait for it. So hopefully, when we do implement the Great and Final merge from v6 to develop, we don't accidentally step on this change. I guess we'll see :/
We do have other Dockerfiles for Alpine, but I don't know which versions of PHP those use, as I'm not particularly familiar with them.