Fixed sorting on non-asset relations in API (FD#23117) #10114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
uberbrady
approved these changes
Sep 22, 2021
| 'created_at', | ||
| 'min_amt', | ||
| 'company_id' | ||
| ]; |
There was a problem hiding this comment.
Love these comments and this column-name per-line thing, so much easier to work with!
|
Thanks @uberbrady. (I honestly don't know how sorting worked before with the relations in the allowed_columns array.....) |
snipe
changed the title
snipe
changed the title
snipe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where some items (non-assets) were not sorting properly on relations via their query scopes.
It also addresses a few places where we were not eager loading relations, causing an n+1 query issue, and adds Supplier as a sortable column via query scope for Accessories.