Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes API Issue when checking out a component #10122

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Sep 23, 2021

Description

When trying to checking out a component that has only one item remaining via API, the system doesn't let to do it because the condition says $component->numRemaining() > $request->get('assigned_qty') and 1 is not higher than 1.

Fixes internal freshdesk #22199

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test Configuration:

  • PHP version: 7.4.16
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@snipe
Copy link
Owner

snipe commented Sep 23, 2021

Derp - that was probably me. (Please don’t git blame lol) - Thanks for the quick fix, Ivan!

@snipe snipe merged commit 3862b64 into snipe:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants