Fixes #8155 - improve the workflow during asset creation

[veenone]

• Fixes Delete, hide or order the default fields from Snipe-it like "asset name" #8155
• Adding 2 checkboxes to hide optional information
• Relocate custom fields location

Description

I'm trying to help improving the workflow during asset creation by adjusting the layout ordering as mentioned in the original issue. I hope this implementation meets the needs of the request

Fixes #8155

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

the new layout has been tested by doing the following:

• Test creating assets without optional fields filled
• Test creating assets with optional fields filled

Test Configuration:

• PHP version: 7.4.27
• MySQL version : 10.4.22
• Webserver version: Apache 2.4.52
• OS version: Windows 10

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Preview

some fields are moved and add 2 checkboxes which disabled by default

the content of each checkboxes group

custom fields location from model is now placed before the checkboxes also to give positional consistency during asset creation

Please inform me if this PR acceptable or not

[snipe]

I'd think we'd need to set a cookie or add an admin setting for that though? It would be pretty annoying to have to hide them every time.

[veenone]

I'd think we'd need to set a cookie or add an admin setting for that though? It would be pretty annoying to have to hide them every time.

Hi @snipe, sorry I was away for vacation.
Thank you for your comment. I will try to implement either cookie / admin setting for it.
It seems like cookie would be easier to do though.. I will try to consider both approach then

[veenone]

hi @snipe ,

sorry for taking some time before I get back to my PC.
cookie has been implemented to keep the preference of the option of the user in the view.

Waiting for your feedback on the change

[snipe]

This looks great - needs a little styling love, but I can handle that part. Sorry for the delay on reviewing :)

[snipe]

What is flexCheckDefault? I can't see where that comes from?

[veenone]

Ah you're right, I made a mistake for this part.

I think it should be :

    <label class="col-md-3 control-label"></label> 
        <div class="col-md-2 col-sm-2 text-left form-check" style="z-index:1;">   

        <input class="form-check-input" type="checkbox" id="optional_info" name="options[]" value="optional" <?php if (!empty (json_decode(Cookie::get('optional_info')))) {if(in_array('optional',json_decode(Cookie::get('optional_info')))) {echo 'checked';} else {echo 'unchecked';}} else {echo 'unchecked';} ?>>
        <label class="form-check-label" for="flexCheckDefault">
        {{ trans('admin/hardware/form.optional_infos') }}
        </label>

and

    <label class="col-md-3 control-label"></label> 
        <div class="col-md-2 col-sm-2 text-left form-check" style="z-index:2;">   
        <input class="form-check-input" type="checkbox" id="order_info" name="options[]" value="order" <?php if (!empty (json_decode(Cookie::get('optional_info')))) {if(in_array('order',json_decode(Cookie::get('optional_info')))) {echo 'checked';} else {echo 'unchecked';}} else {echo 'unchecked';} ?>>
        <label class="form-check-label" for="order_info">
        {{ trans('admin/hardware/form.order_details') }}
    </label>

respectively... sorry about that. but I don't think there's any impact in the behavior

[snipe]

I've reworked this a bit anyhow, so I don't think it will matter when I'm done. (I'm switching it to disclosure arrows instead of checkboxes)

Screen.Recording.2022-06-27.at.10.48.42.AM.mov

[veenone]

It looks waaay better 👍
In fact I just updated my local instance to the latest version and this piece already there 😄

[snipe]

Glad you dig the tweaks! It's also added to the user's screen for lesser used options as well.