Try conditional formatting to support apache 2.2 and 2.4 #11072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <snipe@snipe.net>
snipe
changed the title
2 tasks
|
Anybody manage to test this yet? |
snipe
added
the
🆘 testers-needed
|
🦗🦗🦗🦗🦗🦗🦗🦗🦗 Can anybody please test this? I'm happy to merge it but I need someone to test it. We don't use Apache here. |
|
Closing this, since no one has been able to test :( |
|
This works for me on Apache 2.4.41 as shipped in Ubuntu 20.04. I'd like to see this merged since it's quite bothersome to have to manually edit after each update. |
|
YOLO! @scranfor thanks for following up - it's on develop now and should be on master soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken for 2.4 when we denied access to the web.config file. I haven't tested this since we don't run apache anywhere.