Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #11126: don't entitise custom CSS on the labels view #11127

Merged
merged 1 commit into from
May 17, 2022

Conversation

trav-c
Copy link

@trav-c trav-c commented May 17, 2022

Description

Update labels view to not entitise custom CSS as is already the case in all other views

Fixes #11126

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Generated HTML source review
    Added CSS containing double quotes and greater than signs and manually inspected the resulting (generate) HTML source code on the labels page to verify the custom CSS is not encoded
  • Generated labels font
    Added custom CSS to use the slashed-zero variant of the "Inter" font for labels which requires the use of double quotes and verified that the CSS is correctly interpreted / rendered the browser

Test Configuration:

  • PHP version: 8.1.6
  • MySQL version: 5.6.51 (Percona Server)
  • Webserver version: httpd-2.4.6-97.el7.centos.5.x86_64
  • OS version: CentOS v7

Checklist:

@trav-c trav-c requested a review from snipe as a code owner May 17, 2022 14:20
@welcome
Copy link

welcome bot commented May 17, 2022

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@snipe snipe changed the base branch from master to develop May 17, 2022 14:21
@snipe snipe merged commit 700b4ef into snipe:develop May 17, 2022
@welcome
Copy link

welcome bot commented May 17, 2022

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom CSS is incorrectly encoded on the labels view
2 participants