Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11096 Backup created_at time is incorrect #11133

Merged
merged 2 commits into from
May 17, 2022

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented May 17, 2022

Description

We used to display the backups dates using the date() function, but for v6 we changed to Helper::getFormattedDateObject() that uses Carbon to format the date. Where we shouldn't have any problem because we use UNIX timestamps to show the date, but I believe that in Carbon the timezone is defaulting to UTC, and don't care of the timezone that we have in the env file.

So, as I didn't want to affect the Helper function that we use in other places, I just formatted the timestamp as we used to make it before.

Fixes #11096

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 7.4.16
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@inietov inietov marked this pull request as ready for review May 17, 2022 21:36
@snipe
Copy link
Owner

snipe commented May 17, 2022

Thanks - we're definitely going to get people complaining that the date isn't formatted the way they selected in the settings tho. :(

@snipe snipe merged commit a8eb138 into snipe:develop May 17, 2022
@@ -1044,7 +1044,7 @@ public static function getPDFBranding()
*/
public function getBackups()
{

$settings = Setting::getSettings();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - we're definitely going to get people complaining that the date isn't formatted the way they selected in the settings tho. :(

I fixed that too, here I get the settings, and later I put the format accord to this,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants