Adjust requested assets and models workflow a little bit.

[inietov]

Description

This changes doesn't change behavior a lot, but there was a Requestable Asset Models view that doesn't links to the proper model if you click to their name.

Also when checking this I hit a DB exception if in Requestable Assets view I try to order columns, so the fix is also in this PR, and finally, a tiny tiny fix on the Requested Assets views, where we were showing two blank columns instead of the one that contains the checkin/checkout actions.

Fixes freshdesk 27421

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

• PHP version: 7.4.16
• MySQL version: 8.0.23
• Webserver version: nginx/1.19.8
• OS version: Debian 10

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[snipe]

So IIRC, we don't link to those model listings because the person logged in may not have the ability to view asset model details (i.e. a "regular" user), which would result in 403 errors on everything they click on.

[inietov]

Yeah, just tested it and that's the case. You think it's a good idea to check for permissions to show the link? or I just rollback that change?

[snipe]

Yeah, from a UX perspective, being presented with a link that you can't click on without an error is a bad experience. I'd say check for the gate before presenting the link.

[snipe]

Should this be superadmin, or just the ability to view asset models?

@can('view', \App\Models\AssetModel::class)

[inietov]

I think that's a lot better, yes.

[snipe]

Can we clean up the extra spaces and the extra </td> here? We already close the <td> outside of the loop.

<a href='{{ url("/models/{$requestableModel->id}") }}' > {{ $requestableModel->name }} </a></td>

vs

<a href="{{ url("/models/{$requestableModel->id}") }}">{{ $requestableModel->name }}</a>

[inietov]

Sorry, I have it written differently and the tag remained 😬