Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11193 File Uploads don't show target in Activity report #11204

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented May 26, 2022

Description

I think the linked issue is not exactly how this needs to works, but let me know what you think:

When uploading a file to an asset, license or user the target is already the entity that 'receives' the file... so if the report says that an Action->upload is happening over an Item->Heidi Emerich of Type->user, that's the target, like this.

image

Of course that I can repeat the target with this data... but I opted for add a column called File that contains the file that was uploaded, Since the file is already stored in the ActionLog, I just change a little bit the actionlog transformer and the view of the Activity Report. So the column is hidden by default, and can be activated as preferred. Looking now like this:

image

Fixes #11193

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test Configuration:

  • PHP version: 7.4.16
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian10

Checklist:

@snipe
Copy link
Owner

snipe commented May 26, 2022

This looks pretty solid to me - thanks!

@snipe snipe merged commit 9209675 into snipe:develop May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants