Fixed default ldap version if not specified #11264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
uberbrady
reviewed
Jun 7, 2022
|
Awesome, thanks @uberbrady - I'd love to sneak this into v6.0.3 if we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should hopefully solve some of the LDAP configs that some users have been having issues with. This should prevent the
ldap_search(): Search: Partial results and referral receivederror that could occur if the LDAP version field was left blank in the LDAP settings.Previous versions of Snipe-IT automatically assumed v3 of LDAP (because in 9 years of running this project I have never seen any other version used), but somehow when we had to forklift the old LDAP functionality from v4 to un-do the AdLdap package stuff, that default got dropped in the shuffle.
Next iteration we will likely remove that field in the LDAP settings screen altogether, since LDAP v2 has been EOL forever and LDAP v4 is unlikely. It's pretty much always going to be v3.