Fixes - set crons as app user in installer #11288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <snipe@snipe.net>
uberbrady
reviewed
Jun 9, 2022
There was a problem hiding this comment.
This seems pretty reasonable to me, but the only thing I'm a little worried about is if, in the final crontab - statement, do we have to do a second run_as_app_user there? Or else maybe it'll still put in as root (since the script is running as root). I'm not completely sure tbh.
|
I don't think that should matter? But it's hard to say without a way to test. |
Signed-off-by: snipe <snipe@snipe.net>
|
(I really hate this installer script.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should create the cronjobs (or corncobs, as autocorrect would have it) as the snipeitapp user instead of as root.