Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added models view (and bulk edit) in category detail view #11301

Merged
merged 7 commits into from
Jun 14, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 14, 2022

Previously when you drilled down into a category, you could only see the assets associated through that category. This PR allows you to see (and therefore bulk edit) the models that belong to that category if they are asset models.

Screen.Recording.2022-06-13.at.8.48.19.PM.mov

There is a small UX oddity that I need to fix, adding the same cookie flow to return people back from whence they came after a bulk edit that we do on bulk people and assets, but that's for another PR.

As an added bonus, this also adds the filter onto the models API endpoint to be able to filter by category ID.

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
…not uncheck properly

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! I love that this one little change we made to make the bulk-edit tooling is paying off so many dividends. Can't wait to see it pop up in more spaces! Great work :)

@snipe snipe changed the title Added models view in category details Added models view (and bulk edit) in category detail view Jun 14, 2022
@snipe snipe merged commit 44c0c1b into develop Jun 14, 2022
@snipe snipe deleted the features/models_view_in_categories branch June 14, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants