Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eula blade for licenses/consumables/components and fixes assigned_to for dom_pdf #11379

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Jun 23, 2022

Description

Fixes the assigned_to variable being null by searching with the acceptance->assigned_to_id for user or asset.

Also adds acceptance for components and Consumables. This also temporarily adds a couple new blades for for all three categories. I will clean that up into one nice blade at a later point in time.

Fixes #11355, #3019

Type of change

Please delete options that are not relevant.

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz changed the title adds eula blade for licenses and fixes assigned_to for dom_pdf adds eula blade for licenses/consumables/components and fixes assigned_to for dom_pdf Jun 23, 2022
@snipe
Copy link
Owner

snipe commented Jun 24, 2022

Looks great!

@snipe snipe merged commit 1c25057 into snipe:develop Jun 24, 2022
@snipe snipe changed the title adds eula blade for licenses/consumables/components and fixes assigned_to for dom_pdf Added eula blade for licenses/consumables/components and fixes assigned_to for dom_pdf Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants