Added created_by to users #11383
Merged
Added created_by to users #11383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
uberbrady
approved these changes
Jun 24, 2022
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
uberbrady
requested changes
Jun 24, 2022
| @@ -705,7 +705,7 @@ public function scopeOrderDepartment($query, $order) | |||
| * | |||
| * @return \Illuminate\Database\Query\Builder Modified query builder | |||
| */ | |||
| public function scopeOrderAdmin($query, $order) | |||
| public function scopeCreatedBy($query, $order) | |||
There was a problem hiding this comment.
Should this be scopeOrderCreatedBy()?
| @@ -67,7 +67,7 @@ public function index(Request $request) | |||
| 'users.remote', | |||
| 'users.ldap_import', | |||
|
|
|||
| ])->with('manager', 'groups', 'userloc', 'company', 'department', 'assets', 'licenses', 'accessories', 'consumables', 'adminuser',) | |||
| ])->with('manager', 'groups', 'userloc', 'company', 'department', 'assets', 'licenses', 'accessories', 'consumables', 'createdBy',) | |||
There was a problem hiding this comment.
This is a silly aesthetic thing, but it's weird that we don't normally use snakeCase and here is the one place where we do. But, that's the Laravel convention and we probably ought to follow it, so this is probably exactly how it should be.
|
Thank you for reviewing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am frankly shocked that I didn't have this on the user's table before - seems like a real boner move TBH - everything else in the system records who created the thing, but we somehow missed it 9 years ago and never noticed. (To be fair, nobody asked for it, but still... weird that I'd have missed something so obvious.)
Anyway... this adds a DB column called
created_byto the users table. It is important to note that this is a divergence from our standard convention. We typically use the (very confusing) field nameuser_idto denote the Snipe-IT user id of the person who created the thing - but since it's confusing, I will be changing that over time to use a more commoncreated_by, so it's clearer what that field means. I didn't want to include that in this PR though, since it's a breaking change to the API.In the user view blade, we check to see if that admin has been (soft) deleted, and if it has, we strike it through. If not, we link to the person who created the user.
The API payload is standard for what we return for users, managers, etc.