Only care about the custom field's converted name when updating the custom field itself #11405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11404, this PR switches from us using the
->convertUnicodeDbSlug()
modifier in most places (except when saving the custom field). The recent transliteration issues are a real pain in the bunghole, and at the end of the day, we shouldn't care if the custom fielddb_column
is "correct", just that it agrees with whatever is in on the assets table. When a custom field is updated, update thatdb_column
value in thecustom_fields
table, and then just use the field'sdb_column
value for things moving forward for displaying/editing assets, etc.