Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only care about the custom field's converted name when updating the custom field itself #11405

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 27, 2022

Related to #11404, this PR switches from us using the ->convertUnicodeDbSlug() modifier in most places (except when saving the custom field). The recent transliteration issues are a real pain in the bunghole, and at the end of the day, we shouldn't care if the custom field db_column is "correct", just that it agrees with whatever is in on the assets table. When a custom field is updated, update that db_column value in the custom_fields table, and then just use the field's db_column value for things moving forward for displaying/editing assets, etc.

@snipe snipe requested review from inietov and uberbrady June 27, 2022 21:21
@snipe snipe changed the title Only care about the converted name when updating the custom field itself Only care about the custom field's converted name when updating the custom field itself Jun 27, 2022
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will absolutely be much better. Once we’ve vetted this and it’s working well-enough in the wild, maybe we can remove the warning when the fieldnames don’t line up perfectly right? Still, baby steps - let’s get there first. Nice work!

@snipe snipe merged commit 14d8fb6 into develop Jun 28, 2022
@snipe snipe deleted the fixes/use_db_column_instead_of_converted_value branch August 1, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants