Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #9757 - Added model uploads #11412

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Fixed #9757 - Added model uploads #11412

merged 5 commits into from
Jun 29, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 28, 2022

This adds a file upload option to asset models.

Screen Shot 2022-06-28 at 4 18 32 PM

Screen Shot 2022-06-28 at 4 19 42 PM

Next Steps:

  • Rename the AssetFileRequest to be more generic
  • Possibly Traitify files so that there's less repetition
  • Add files endpoint to API so we can BS tables those mofos

Fixes #9757 and FD-28554

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe requested a review from uberbrady June 28, 2022 23:58
@snipe snipe changed the title Features/model uploads Added model uploads Jun 29, 2022
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks SUPER clean, very nice. Should be a great feature. I had a couple of comments about the use of file_get_contents() - I think the Storage facade gives us some more 'fluent' ways of approaching those files. But that's not enough of a big deal to stop the PR. I'm super-excited about all these great new features we're adding, all throughout!

@snipe snipe merged commit 9dbb355 into develop Jun 29, 2022
@snipe snipe changed the title Added model uploads Fixed #9757 - Added model uploads Jun 29, 2022
@snipe snipe deleted the features/model_uploads branch June 29, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants