Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a closing div tag around the mail text help block, this was cau… #11635

Merged

Conversation

exula
Copy link
Contributor

@exula exula commented Aug 9, 2022

This adds a closing div around the email test help text, the missing closing div was causing labels further down the page to be formatted incorrectly.

Description

Before this change, the Dashboard Message on /admin/settings and all labels below that were aligned too far left. Once adding this extra closing div things line up nicely.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

…sing labels further down the page to be formatted in correctly
@snipe
Copy link
Owner

snipe commented Aug 9, 2022

Good catch, thank you!

@snipe snipe merged commit de449fd into snipe:develop Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants