Fixed Search in activity report for full name in relation

[inietov]

Description

Well this is not a 'cool' or 'good looking', probably not 'the better'. In fact, I'm pretty sure it's not the better. But yeah, it's 'a fix'. When searching trough the Activity Report if you know the complete name of the user, the search doesn't return any result.

I added a condition to do this in the searchable trait when looking inside the relations of the action_logs table. I spent more hours than I like to admit looking for a solution and this is the only thing I could think of. Let me know if something is escaping my mind, and if not, well, I think this is working for now.

Fixes internal freshdesk 29988

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

• PHP version: 8.1
• MySQL version: 8.0.23
• Webserver version: nginx/1.19.8
• OS version: Debian 10

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[snipe]

This is legitimately pretty terrible lol - but I have no better suggestions right now that are not somehow worse. I'm sure there's a more elegant way down the road, but it will take some time to figure out. Thanks for this :)