Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send notifications when Acceptance Assets actions occur [sc-9917] #11661

Merged
merged 6 commits into from
Aug 30, 2022

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Aug 11, 2022

Description

When users got checked out assets to them, if the asset got the Accept/Decline functionality we don't send notifications. Some customers want to know if the asset was declined, but I figure out that maybe if the asset is accepted we also want to send a notification. I only add notifications via mail this time...

As always, let me know if something looks funky or a better solution is available request the changes :D

Fixes shortcut 9917

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@ajsy
Copy link
Contributor

ajsy commented Oct 11, 2022

very nice feature thank you.
I tested and it's working as expected with the assets but not with accessories, i got the notification when declined the acceptance but the item itself not checked back to accessory inventory.

@sarang2502
Copy link

Hello @inietov

Is it possible to disable this feature? In our case, we have tickets generated to the reply-to email. Don't need this feature and finding for any toggle button which I am missing in settings. Recently upgraded to latest version and facing this.

Appreciate your work and response back.

Thanks,
SR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants