Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notes to audit mail notification #11764

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Added notes to audit mail notification #11764

merged 2 commits into from
Sep 27, 2022

Conversation

BasO12
Copy link
Contributor

@BasO12 BasO12 commented Aug 31, 2022

Description

As the title says, any notes added to an asset will appear in the next/upcoming audit notification. This is relevant for our company and might be of use to others.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

By adding notes to a test asset, changing the audit date to today and pinging the scheduler to generate a notification (see screenshot attached)

Test Configuration:

  • PHP version: 7.4.30
  • MariaDB version: 10.5.15
  • Webserver version: Apache2 2.4.54
  • OS version: Debian 10

Checklist:

  • [x ] I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
  • [x ] I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
    Screenshot 2022-08-31 132220

@BasO12 BasO12 requested a review from snipe as a code owner August 31, 2022 11:25
@welcome
Copy link

welcome bot commented Aug 31, 2022

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@snipe snipe merged commit c194c8a into snipe:develop Sep 27, 2022
@welcome
Copy link

welcome bot commented Sep 27, 2022

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants