Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #9801 #11199 Default Values for Checkbox Field Types Unaccessible #11830

Merged

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Sep 15, 2022

Description

I love when a proper PR fixes a couple or more of issues. When we had an element type of checkbox in a custom field, and we tried to assign default values to that element, the controls doesn't show up properly, so now they are showing and functioning nicely. Also, while fixing this I ended up addressing an issue where when changing an element, textbox for example, with a format of type numeric, if we change it to a radiobutton or a checkbox, they conserve the numeric format and we can't set values alphanumeric to those checkboxes, making 'em not usable.

Fixes #9801 #11199

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@snipe
Copy link
Owner

snipe commented Sep 15, 2022

Excellent work!

@snipe snipe merged commit 51d7f2b into snipe:develop Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants