Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #11847 404 error during Import if a checkout type of location is specified and no checkout location is passed #11854

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Sep 20, 2022

Description

Adds a condition to see if a checkout location is passed from the CSV to the importer. I just ignored the field if the CSV have the field empty, because looking at the code, rtd_location is used as base checked-out to location, and then overwriten for the one passed in checkout_location, so I thought the best approach was to not look for a location if no location is specified.

Fixes #11847

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1.10
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@snipe snipe merged commit a7b83fc into snipe:develop Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants