Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #11521 - Add option to switch to using status meta from status label name #11893

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented Sep 29, 2022

This adds the option to pick whether you want the pie chart on the dashboard to reflect the status label name or the status label type, and adds a database field to remember your choice (found in Admin > General).

Screen Shot 2022-09-29 at 4 18 27 AM

Screen Shot 2022-09-29 at 4 18 40 AM

Screen Shot 2022-09-29 at 4 18 52 AM

The "Assets by Status" option includes and respects the colors selected in the status labels section, while they wouldn't make sense in the "Assets by Status Type", since we don't use colors anywhere else there.

Screen Shot 2022-09-29 at 4 28 44 AM

Eventually I'd like to make this a switchable tabbed option on the dashboard and deprecate the select box, since I hate adding extraneous database fields and UI choices like this, but I also know that if I change this out from under existing users, we'll get hate mail for it.

I had wanted to save this feature for the dashboard revamp, but this is a first stab at this issue, I guess.

This also adds a transformer for the pie charts so we have potential flexibility with other options moving forward and simplifies some of that controller code.

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe changed the title Fixed #11521 - switch to using status meta from status label name Fixed #11521 - Add option to switch to using status meta from status label name Sep 29, 2022
@snipe
Copy link
Owner Author

snipe commented Sep 29, 2022

@uberbrady if you can give me a hand when we get back from JNUC to see if we can jerry-rig the legend to show totals, I'd appreciate it. Every way I've tried has been gross. (When you mouse over the sections, it shows you the count, but if I put them as part of the labels so they show up in the legend, they show up twice in the tooltip when you mouseover the pie sections. Grr.)

Screen Shot 2022-09-29 at 4 26 33 AM

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense to me, and looks good. I can help with the legend stuff you were talking about today.

@snipe snipe merged commit 9c6fa18 into develop Sep 29, 2022
@snipe snipe deleted the features/switch_dash_pie_to_status_type branch September 29, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants